Skip to content

Add test_whole_domain plus minor misc. improvements #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Sep 22, 2021

No description provided.

@maresb
Copy link
Contributor Author

maresb commented Sep 22, 2021

Follow-up from #5 (comment)

@bschoening bschoening merged commit 00e56d2 into mysto:main Sep 22, 2021
@maresb maresb deleted the tests branch September 22, 2021 21:07
@bschoening
Copy link
Member

bschoening commented Sep 24, 2021

Hi, I had to back out test_whole_domain as the test was failing on the import statement when built and run by travis and on my local Mac.

$ python ff3/ff3_test.py
ERROR: test_whole_domain (main.TestFF3)

Traceback (most recent call last):
File "/Users/brad/mysto/python-fpe/ff3/ff3_test.py", line 230, in test_whole_domain
perm = [int(reverse_string(
File "/Users/brad/mysto/python-fpe/ff3/ff3_test.py", line 231, in
c.decrypt(c.encrypt(
File "/Users/brad/mysto/python-fpe/ff3/ff3.py", line 126, in encrypt
return self.encrypt_with_tweak(plaintext, self.tweak)
File "/Users/brad/mysto/python-fpe/ff3/ff3.py", line 176, in encrypt_with_tweak
raise ValueError(f"message length {n} is not within min {self.minLen} and max {self.maxLen} bounds")
ValueError: message length 10 is not within min 20 and max 192 bounds

https://app.travis-ci.com/github/mysto/python-fpe/jobs/539306809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants