refactor: use builder pattern for CallToolResult and simplify lambda expressions in tests #652
+405
−202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@codeboyzhou thanks for your contribution. As part of this PR, please:
|
codeboyzhou
added a commit
to codeboyzhou/mcp-java-sdk
that referenced
this pull request
Nov 20, 2025
…ol#652 - Mark McpSchema.CallToolResult#CallToolResult(java.lang.String, java.lang.Boolean) as deprecated. - Update McpAsyncServer and McpStatelessAsyncServer to use the builder instead of that constructor. - Remove test usages of that constructor as well.
Contributor
Author
@Kehrlann ok, I have finished these three feedbacks and commit again. |
codeboyzhou
added a commit
to codeboyzhou/mcp-java-sdk
that referenced
this pull request
Nov 20, 2025
…constructor for the Resource class
Contributor
Author
Kehrlann
approved these changes
Nov 21, 2025
Contributor
Kehrlann
left a comment
Kehrlann
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
…expressions in tests
…ol#652 - Mark McpSchema.CallToolResult#CallToolResult(java.lang.String, java.lang.Boolean) as deprecated. - Update McpAsyncServer and McpStatelessAsyncServer to use the builder instead of that constructor. - Remove test usages of that constructor as well.
…constructor for the Resource class
Kehrlann
force-pushed
the
refactor-replace-deprecated
branch
from
060d6cd to
927696e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
CallToolResultto replace deprecated method usages.AbstractMcpClientServerIntegrationTests.Motivation and Context
Simplify code and improve readability.
How Has This Been Tested?
Just run the tests because there is no logic changes.
Breaking Changes
No.
Types of changes
Checklist
Additional context
No.