Adding check if file not found and cleanups (#14987) #15032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
changed the title
Carreau
force-pushed
the
fix/print-warning-if-config-not-opened
branch
from
014f579 to
c1a66c7
Compare
Member
|
If anything I think the logic should go up in traitlets; and we should carefully think about the warnings; I think it's ok to not have any config file, but warn if one if unreadable. I need to have a bit more time to wrap my head arround this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what this PR do?
finds the file path,
if not found then prints warning.
tested with test_application.py file
clean-up code with better logic.
Fixes #14987