make component column string public #443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lastTwoBrainCells what is the motivation of this PR? |
| private val ORIG_ID = "orig_id" | ||
| private val MIN_NBR = "min_nbr" | ||
| private val CNT = "cnt" | ||
| private val CHECKPOINT_NAME_PREFIX = "connected-components" | ||
| val COMPONENT = "component" |
There was a problem hiding this comment.
Why not to add an alternative merhod run(graph, algorithm, broadcastThreshold, checkpointInterval, intermediateStorageLevel, componentColName) instead and update the public API? Cause this one is a constant value that works fine for default, but it would be strange to see it as a part of the public API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.