Skip to content

Add connection method to find multiple relationships easily #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

goungoun
Copy link

This PR added connection method to generate motif query easier. See the examples in test case.

@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #264 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   88.49%   88.55%   +0.06%     
==========================================
  Files          20       20              
  Lines         739      743       +4     
  Branches       57       58       +1     
==========================================
+ Hits          654      658       +4     
  Misses         85       85
Impacted Files Coverage Δ
src/main/scala/org/graphframes/GraphFrame.scala 86.82% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a142721...2982bf5. Read the comment docs.

@goungoun goungoun changed the title add connection method to find multiple relationships easily Add connection method to find multiple relationships easily Mar 13, 2018
@felixcheung
Copy link
Member

this just create the motif pattern as a string?

@goungoun
Copy link
Author

Yes. I was searching for Cypher like syntax for (v1)-[*1..5]->(v2) pattern, but I was not able to find it. For a query to find some relations in depth, typing the long pattern manually was not good experience actually. It is just a starting point, and applying any better idea will be appreciated.

@felixcheung
Copy link
Member

I see. Kinda like this http://graphframes.github.io/user-guide.html#tab_python_3

Would it more useful to implement support for variable pattern (v1)-[*1..5]->(v2)? It shouldn't be very difficult to do..

@goungoun
Copy link
Author

Right. But, I am not sure about the syntax is good enough. When I google it literally as it is, it detects the query from a bot and blocks my browser. The other concern is, if it is only for Neo4j not open Cyper standards, will it be ok to use?

@felixcheung
Copy link
Member

I think that's Cypher syntax right? I think that's good to have.
https://www.opencypher.org/
https://s3.amazonaws.com/artifacts.opencypher.org/openCypher9.pdf
"Variable-length pattern matching"

@goungoun
Copy link
Author

goungoun commented Mar 27, 2018

Great! Variable-length pattern matching!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants