Skip to content

Chore: Update renovate config #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Chore: Update renovate config #1812

wants to merge 1 commit into from

Conversation

tolzhabayev
Copy link
Collaborator

@tolzhabayev tolzhabayev commented May 20, 2025

What this PR does / why we need it:

Renovate failed to look up the following dependencies: Failed to look up npm package @libs/output, Failed to look up npm package @libs/version
Files affected: packages/create-plugin/package.json, packages/sign-plugin/package.json

(from here)

Copy link
Contributor

github-actions bot commented May 20, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@tolzhabayev tolzhabayev added dependencies Update one or more dependencies version no-changelog Don't include in changelog and version calculations labels May 20, 2025
@tolzhabayev tolzhabayev requested review from jackw and removed request for oshirohugo and s4kh May 20, 2025 11:49
@tolzhabayev tolzhabayev requested a review from Copilot May 20, 2025 11:50
"includePaths": ["package.json", "packages/**", "docusaurus/**", ".github"],
"ignoreDeps": ["react", "react-dom", "@stylistic/eslint-plugin-ts", "lerna", "@grafana/scenes"],
"includePaths": ["package.json", "packages/**", "docusaurus/**", ".github/**"],
"ignoreDeps": ["react", "react-dom", "@stylistic/eslint-plugin-ts", "lerna", "@grafana/scenes", "@libs/output"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we ignoring "@libs/output" is it because it's an internal lib?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix

Renovate failed to look up the following dependencies: Failed to look up npm package @libs/output, Failed to look up npm package @libs/version

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Renovate configuration to address dependency resolution issues and ensure proper file inclusion during package updates.

  • Updated "includePaths" to recursively include files under the .github folder.
  • Added "@libs/output" to the ignoreDeps list to address internal dependency resolution issues.
Comments suppressed due to low confidence (2)

.github/renovate.json5:4

  • Confirm that extending 'includePaths' to include subdirectories under '.github' is intentional. If so, consider adding documentation to clarify which additional files should be processed by Renovate.
"includePaths": ["package.json", "packages/**", "docusaurus/**", ".github/**"],

.github/renovate.json5:5

  • Ensure that adding '@libs/output' to the ignoreDeps list properly addresses the resolution issue and matches your intended dependency management strategy.
"ignoreDeps": ["react", "react-dom", "@stylistic/eslint-plugin-ts", "lerna", "@grafana/scenes", "@libs/output"],

@tolzhabayev tolzhabayev requested a review from hugohaggmark May 20, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version no-changelog Don't include in changelog and version calculations
Projects
Status: 🔬 In review
Development

Successfully merging this pull request may close these issues.

3 participants