-
Notifications
You must be signed in to change notification settings - Fork 31
Chore: Update renovate config #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
"includePaths": ["package.json", "packages/**", "docusaurus/**", ".github"], | ||
"ignoreDeps": ["react", "react-dom", "@stylistic/eslint-plugin-ts", "lerna", "@grafana/scenes"], | ||
"includePaths": ["package.json", "packages/**", "docusaurus/**", ".github/**"], | ||
"ignoreDeps": ["react", "react-dom", "@stylistic/eslint-plugin-ts", "lerna", "@grafana/scenes", "@libs/output"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we ignoring "@libs/output"
is it because it's an internal lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fix
Renovate failed to look up the following dependencies: Failed to look up npm package @libs/output, Failed to look up npm package @libs/version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Renovate configuration to address dependency resolution issues and ensure proper file inclusion during package updates.
- Updated "includePaths" to recursively include files under the .github folder.
- Added "@libs/output" to the ignoreDeps list to address internal dependency resolution issues.
Comments suppressed due to low confidence (2)
.github/renovate.json5:4
- Confirm that extending 'includePaths' to include subdirectories under '.github' is intentional. If so, consider adding documentation to clarify which additional files should be processed by Renovate.
"includePaths": ["package.json", "packages/**", "docusaurus/**", ".github/**"],
.github/renovate.json5:5
- Ensure that adding '@libs/output' to the ignoreDeps list properly addresses the resolution issue and matches your intended dependency management strategy.
"ignoreDeps": ["react", "react-dom", "@stylistic/eslint-plugin-ts", "lerna", "@grafana/scenes", "@libs/output"],
What this PR does / why we need it:
@libs/output
library(from here)