mtmd : (WIP) add ultravox audio input #13623
Draft
+95,165
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok somehow it works magically, the code is still nowhere near finish Tested using first 6 seconds from https://www.youtube.com/watch?v=vP4iY1TtS3s 
|
ngxson
commented
May 19, 2025
Comment on lines
+3
to
+11
| #define MINIAUDIO_IMPLEMENTATION | ||
| #define MA_NO_ENCODING | ||
| #define MA_NO_DEVICE_IO | ||
| #define MA_NO_RESOURCE_MANAGER | ||
| #define MA_NO_NODE_GRAPH | ||
| #define MA_NO_ENGINE | ||
| #define MA_NO_GENERATION | ||
| #define MA_API static | ||
| #include "miniaudio.h" |
There was a problem hiding this comment.
@ggerganov I initially use dr_wav.h here, but I struggled to write myself a resampling algorithm to downsample/upsample audio to 16KHz. I ended up using miniaudio.h here which provide decoding wav, mp3, flac, etc while also come with resampling built-in.
However, the caveat is that this single-header library is 3MB of code, and most of the components are disabled upon compilation as you see here.
What do you think about keeping this lib? I think the other components can be useful for TTS, as it allow us to play the generated audio without an external command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #12745
TODO writing more in details:
miniaudio.h, why it's compiled in as separated lib (but static link)?imagetomediaorbuffermtmd_API