Re-add support for memoryless storage on A7 #8725
Open
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-adds memoryless storage support for the Metal backend on Apple A7 that was included in the original #8247 but was removed in #8439.
Change 1:
MTLGPUFamily::Apple2toMTLGPUFamily::Apple1This is valid since
Apple1corresponds to Apple A7, and it has been tested to have support.Change 2: Addition of
else { version.at_least((11, 0), (10, 0), (10, 0), (1, 0), os_type) }This is valid. We're testing for family check support first then only when it's not supported testing for OS versions.
The version tested for are macOS 11.0, iOS 10.0, tvOS 10.0 and visionOS 1.0.
For macOS, since the condition checks for 11.0, a family check is forced (
MTLGPUFamilyis introduced in 10.15), which would then give us accurate information on support.Apple A6 can have an iOS version above 10 while not supporting memoryless, however, they do not support Metal.
Oldest Apple TV that supports tvOS 10 is the Apple TV HD, which contains an Apple A8.
visionOS 1.0 definitely supports family checks, which would then skip the version check.
Testing
Was already tested in #8247.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.