FIX: Flaky DST handling tests in post_event_spec #36677
Open
+106
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DST handling system tests were flaky because they only set the user's profile timezone preference, not the browser's actual timezone. The tests expected times displayed in Europe/Paris or America/New_York, but the browser used the CI machine's default timezone instead. Added `timezone:` metadata to the test contexts, which Playwright uses to set the browser's `timezoneId`. This ensures consistent behavior regardless of the machine running the tests.
CvX
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DST handling system tests were flaky because they only set the user's profile timezone preference, not the browser's actual timezone. The tests expected times displayed in Europe/Paris or America/New_York, but the browser used the CI machine's default timezone instead.
Added
timezone:metadata to the test contexts, which Playwright uses to set the browser'stimezoneId. This ensures consistent behavior regardless of the machine running the tests.