UX: Warn moderators before they lock themselves out of a category #36663
+123
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moderators with `moderators_manage_categories` enabled change category permissions, they could accidentally remove their own access, requiring admin intervention to fix. This adds a client-side confirmation dialog that warns moderators before saving permission changes that would lock them out. If confirmed, the changes are saved and the user is redirected to the home page. Changes: - Add `_wouldLoseAccess()` check in edit-category controller that compares new permissions against the user's group memberships - Show confirmation dialog via `dialog.yesNoConfirm()` before saving - Redirect to home page after confirmed save (since user can no longer access the category edit page) - Fix `onSelectGroup` to properly set `group_id` for custom groups by looking up from `site.groups` (was only working for auto groups) Ref - https://meta.discourse.org/t/390978
github-actions
bot
added
the
i18n
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moderators with
moderators_manage_categoriesenabled change category permissions, they could accidentally remove their own access, requiring admin intervention to fix.This adds a client-side confirmation dialog that warns moderators before saving permission changes that would lock them out. If confirmed, the changes are saved and the user is redirected to the home page.
Changes:
_wouldLoseAccess()check in edit-category controller that compares new permissions against the user's group membershipsdialog.yesNoConfirm()before savingonSelectGroupto properly setgroup_idfor custom groups by looking up fromsite.groups(was only working for auto groups)Here's how the confirm dialog looks like
Ref - https://meta.discourse.org/t/390978