Add a new --push flag to the pr create command #12140
Conversation
TheoBrigitte
temporarily deployed
to
cli-automation
GitHub Actions
Inactive
cliAutomation
added
the
external
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --push flag to the gh pr create command to automatically push the current branch to the first available repository, bypassing the interactive prompt that normally asks "Where should we push the branch?"
Key changes:
- Added
PushFirstboolean field toCreateOptionsstruct - Registered
--pushflag in command setup - Modified push destination selection logic to skip prompting when flag is set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| selectedOption := 0 | ||
| if !opts.PushFirst { | ||
| // Prompt the user to select a repo to push to when push flag is not set. | ||
| selectedOption, err = opts.Prompter.Select(fmt.Sprintf("Where should we push the '%s' branch?", currentBranch), "", pushOptions) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
When --push is set and there are no pushable repositories available (e.g., len(pushableRepos) == 0), selectedOption defaults to 0, which may select "Create a fork" instead of a repository. This behavior is inconsistent with the flag's description "Push the current branch to the first available repository."
Consider adding validation to ensure at least one pushable repository exists when using --push, or clarify the behavior when no repositories are available. For example:
selectedOption := 0
if !opts.PushFirst {
// Prompt the user to select a repo to push to when push flag is not set.
selectedOption, err = opts.Prompter.Select(fmt.Sprintf("Where should we push the '%s' branch?", currentBranch), "", pushOptions)
if err != nil {
return nil, err
}
} else if len(pushableRepos) == 0 {
return nil, fmt.Errorf("no pushable repositories found; cannot use --push flag")
}There was a problem hiding this comment.
The check for len(pushableRepos) == 0) is already present on line 917
2 participants
This PR introduces a new --push flag to the pr create command, allowing users to directly push their branches to the remote repository when creating a pull request without having to select the push option interactively.