Skip to content

util/acct: implement a new hierarchical accounting system #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

util/acct: implement a new hierarchical accounting system #398

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
89f2f93
ci: rebase on archlinux
dvdhrm May 9, 2025
775a93e
build: add an internal Rust library
dvdhrm Apr 24, 2025
136ffa7
build: split rust-lib into rlib & clib
dvdhrm Apr 30, 2025
ae650a1
rlib: export generated symbols
dvdhrm Apr 30, 2025
4337da4
build: sanitize bindgen arguments
dvdhrm Apr 30, 2025
6277b84
build: run doctest with new meson
dvdhrm Apr 30, 2025
e6fe014
build: loosen build requirements
dvdhrm May 5, 2025
d3020a5
build: avoid comparators in MSVs
dvdhrm May 9, 2025
03aedff
build: guard doctests by !cross_compile
dvdhrm May 9, 2025
9613a22
util/acct: implement a new hierarchical accounting system
dvdhrm Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ci: rebase on archlinux 
Switch the base image again from Fedora to Arch Linux. This requires us
to disable SELINUX in the unit-tests, but those will be run by the
packit integration, so we should be fine.

The advantages are:

 * Image builds take *significantly* less time: 10min for Fedora, 3min
   for Arch Linux (on the same infrastructure).

 * Images are significantly smaller in size: 6GiB for Fedora, 3GiB for
   ArchLinux (with the same packages).

We also get rolling releases, allowing us to control at which point we
can update. We do not expose the CI system to untrusted inputs, anyway
(nor do we pass sensitive data to it).

Signed-off-by: David Rheinsberg <[email protected]>
  • Loading branch information
@dvdhrm
dvdhrm committed May 9, 2025
commit 89f2f938b236fd0ebec0769fe58ae45568861a6f
44 changes: 18 additions & 26 deletions .github/workflows/meson-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,31 +36,29 @@ jobs:
# since it clashes with sd-bus used by the launcher. This test also
# builds documentation and related resources.
- id: "release"
name: "RELEASE @ CLANG-X86_64 @ +TEST -VALGRIND @ -APPARMOR +AUDIT +DOCS +LAUNCHER +SELINUX"
name: "RELEASE @ CLANG-X86_64 @ +TEST -VALGRIND @ -APPARMOR +AUDIT +DOCS +LAUNCHER -SELINUX"

# Explicitly set all options here to document them.
buildtype: "debugoptimized"
cc: "clang"
cflags: "-Werror"
image: "ghcr.io/bus1/dbrk-ci-fedora:latest"
m32: "no"
image: "ghcr.io/readaheadeu/rae-ci-archlinux:latest"
rustflags: ""
setupargs: "-Daudit=true -Ddocs=true -Dlauncher=true -Dselinux=true"
setupargs: "-Daudit=true -Ddocs=true -Dlauncher=true"
test: "yes"
valgrind: "no"
warnlevel: "2"

# A release build with `-m32` to test on 32-bit.
# A release build with `--cross-file lib32` to test on 32-bit.
- id: "32bit"
name: "RELEASE @ CLANG-I686 @ +TEST -VALGRIND @ -APPARMOR +AUDIT -DOCS +LAUNCHER -SELINUX"
name: "RELEASE @ CLANG-I686 @ +TEST -VALGRIND @ -APPARMOR -AUDIT -DOCS +LAUNCHER -SELINUX"

buildtype: "debugoptimized"
cc: "clang"
cflags: "-m32 -Werror"
image: "ghcr.io/bus1/dbrk-ci-fedora:latest"
m32: "yes"
cflags: "-Werror"
image: "ghcr.io/readaheadeu/rae-ci-archlinux:latest"
rustflags: "--target i686-unknown-linux-gnu"
setupargs: "-Daudit=true -Dlauncher=true"
setupargs: "-Dlauncher=true --cross-file lib32"
test: "yes"
warnlevel: "2"

Expand All @@ -73,7 +71,7 @@ jobs:
buildtype: "debugoptimized"
cc: "clang"
cflags: "-Werror"
image: "ghcr.io/bus1/dbrk-ci-fedora:latest"
image: "ghcr.io/readaheadeu/rae-ci-archlinux:latest"
setupargs: "-Daudit=true -Dlauncher=false"
test: "yes"
valgrind: "yes"
Expand All @@ -82,26 +80,26 @@ jobs:
# A reduced build with `-O0` to verify we do not rely on dead-code
# elimination.
- id: "O0-PLAIN"
name: "PLAIN @ GCC-X86_64 @ +TEST -VALGRIND @ -APPARMOR +AUDIT -DOCS +LAUNCHER +SELINUX"
name: "PLAIN @ GCC-X86_64 @ +TEST -VALGRIND @ -APPARMOR +AUDIT -DOCS +LAUNCHER -SELINUX"

buildtype: "plain"
cc: "gcc"
cflags: "-O0 -Werror"
image: "ghcr.io/bus1/dbrk-ci-fedora:latest"
setupargs: "-Daudit=true -Dlauncher=true -Dselinux=true"
image: "ghcr.io/readaheadeu/rae-ci-archlinux:latest"
setupargs: "-Daudit=true -Dlauncher=true"
test: "yes"
warnlevel: "2"

# An aggressive -O3 -DNDEBUG build that verfies that we properly
# follow strict aliasing rules and do not rely on debug builds.
- id: "O3-NDEBUG"
name: "OPTIMIZED @ GCC-X86_64 @ +TEST -VALGRIND @ -APPARMOR +AUDIT -DOCS +LAUNCHER +SELINUX"
name: "OPTIMIZED @ GCC-X86_64 @ +TEST -VALGRIND @ -APPARMOR +AUDIT -DOCS +LAUNCHER -SELINUX"

buildtype: "release"
cc: "gcc"
cflags: "-O3 -Werror -DNDEBUG"
image: "ghcr.io/bus1/dbrk-ci-fedora:latest"
setupargs: "-Daudit=true -Dlauncher=true -Dselinux=true"
image: "ghcr.io/readaheadeu/rae-ci-archlinux:latest"
setupargs: "-Daudit=true -Dlauncher=true"
test: "yes"
warnlevel: "2"

Expand All @@ -113,11 +111,12 @@ jobs:
buildtype: "debugoptimized"
cc: "clang"
cflags: "-Werror"
image: "ghcr.io/bus1/dbrk-ci-fedora:latest"
image: "ghcr.io/readaheadeu/rae-ci-archlinux:latest"
setupargs: "-Dlauncher=false"
test: "yes"
warnlevel: "2"

# Run on Ubuntu to test the AppArmor integration.
- id: "ubuntu"
name: "RELEASE @ CLANG-X86_64 @ +TEST -VALGRIND @ +APPARMOR +AUDIT -DOCS +LAUNCHER -SELINUX"

Expand All @@ -131,25 +130,18 @@ jobs:

container:
image: ${{ matrix.image }}
options: --user root

env:
CC: ${{ matrix.cc }}
CFLAGS: ${{ matrix.cflags }}
RUSTFLAGS: ${{ matrix.rustflags }}

runs-on: "ubuntu-latest"

steps:
- name: "Fetch Sources"
uses: actions/checkout@v4

- name: "Setup 32-bit Environment"
if: matrix.m32 == 'yes'
run: |
echo \
"PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/share/pkgconfig" \
>> $GITHUB_ENV

- name: "Setup Meson"
run: |
meson setup \
Expand Down
Loading