Add some standard stats to Debug.GetStats method #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds standard fields as expected by the org.freedesktop.DBus.Debug.Stats.GetStats method: - Serial - ActiveConnections - IncompleteConnections - MatchRules - BusNames Since these fields are essentially summing the per-namespace stats over all peers, these stats are easy to gather. However, this commit does not expose Peak* stats as these would require tracking max matches and bus names over the lifetime of dbus-broker. Arguably, the # of connections, match rules and bus names are more important. See bus1#390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds standard fields as expected by the org.freedesktop.DBus.Debug.Stats.GetStats method:
Since these fields are essentially summing the per-namespace stats over all peers, these stats are easy to gather. However, this commit does not expose Peak* stats as these would require tracking max matches and bus names over the lifetime of dbus-broker. Arguably, the # of connections, match rules and bus names are more important.
See #390