Add notify-reload support to dbus-broker #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slee649
force-pushed
the
user/seaeunlee/notify-reload-support
branch
3 times, most recently
from
2d1814f to
cabe8fa
Compare
bluca
reviewed
Feb 27, 2025
slee649
force-pushed
the
user/seaeunlee/notify-reload-support
branch
from
cabe8fa to
ba5c384
Compare
dvdhrm
reviewed
Apr 25, 2025
dvdhrm
requested changes
Apr 28, 2025
slee649
force-pushed
the
user/seaeunlee/notify-reload-support
branch
from
ba5c384 to
f54c335
Compare
|
Hey @dvdhrm , thanks for the review! |
slee649
force-pushed
the
user/seaeunlee/notify-reload-support
branch
from
f54c335 to
1e75da9
Compare
bluca
reviewed
Apr 29, 2025
src/launch/launcher.c
Outdated
| r = sd_notify(false, "RELOADING=1"); | ||
| r = sd_notifyf(/* unset_environment = */ false, | ||
| "RELOADING=1\n" | ||
| "MONOTONIC_USEC=" USEC_FMT, |
There was a problem hiding this comment.
../src/launch/launcher.c:1173:41: error: expected ‘)’ before ‘USEC_FMT’
1173 | "MONOTONIC_USEC=" USEC_FMT,
Use "MONOTONIC_USEC=%" NSEC_PRI, instead and it should work
There was a problem hiding this comment.
Also you need to pass it through nsec_to_usec() given the helper returns nanoseconds and the API takes microseconds
slee649
force-pushed
the
user/seaeunlee/notify-reload-support
branch
from
1e75da9 to
2d138f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbus-broker supports reload but the service type is
notify. This PR updates the service type tonotify-reload.