feat(BFormSelect): add properties to add styling for option element #2929
Conversation
|
|
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 76 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
VividLemon
left a comment
VividLemon
left a comment
There was a problem hiding this comment.
Something appears to be messed up with your environment.
I'd recommend going into your github fork,
https://github.com/anrolmar/bootstrap-vue-next
Discard your commits and pull the upstream
Then on your local environment, git reset --hard ${hash}
Then write your changes again
That said, we don't want this optionsAttrs as a prop on BFormSelect, we want it in ex1Options (from your example)
So ex1Options might look like
type BFormSelectOptionsObject = Record<string, unknown>
const ex1Options: BFormSelectOptionsObject[] = [
{ attrs: { style:'background: red; color: white'} },
{ attrs: { style:'background: red; color: blue'} },
{ attrs: { style:'background: red; color: red'} },
]That way each can independently be styled. Then on the BFormSelectOption do a simple v-bind="option.attrs"
2 participants
Describe the PR
Small replication
If we want to set some styling for the option element, we could do:
<BFormSelect v-model="selected" :options="ex1Options" :options-attrs="{ style:'background: red; color: white'}" />so the result would be
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied