Skip to content

feat(b-media): improve aside right handling #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacobmllr95 merged 8 commits into from
Oct 28, 2020
Merged

feat(b-media): improve aside right handling #5965

jacobmllr95 merged 8 commits into from
Oct 28, 2020
+95 −78

Conversation

@jd-solanki
Copy link
Contributor

@jd-solanki jd-solanki commented Oct 26, 2020 •
edited by jacobmllr95
Loading

Describe the PR

This PR is a follow-up to #5121 and removes the usage of utility classes <b-media>.
It also introduces a new right prop on <b-media-aside>.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented Oct 26, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/e2a3vtlzl
✅ Preview: https://bootstrap-vue-git-fix-utility-classes.bootstrap-vue.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba1ac73:

Sandbox Source
BootstrapVue Starter Project Configuration

@jacobmllr95 jacobmllr95 self-requested a review October 26, 2020 11:15
@jacobmllr95 jacobmllr95 added PR: Patch Requires patch version bump Type: Fix labels Oct 26, 2020
@jacobmllr95 jacobmllr95 changed the title fix(b-media): removed utility classes and added style (#5117) fix(b-media): removed the usage of utility classes Oct 26, 2020
jacobmllr95
jacobmllr95 requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jacobmllr95 jacobmllr95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to generally add add media-aside class and a right prop to BMediaAside.
Based on the right prop, the media-aside-right class would be added.
This could then reset the the default margin-right on media-aside and set the margin-left.

The tests need also some adjustments.

@jd-solanki
Copy link
Contributor Author

jd-solanki commented Oct 26, 2020

hi @jackmu95,

Thanks for your suggestions. I have made changes please review it and let me know if you have any issues or suggestions.

Also, I don't know much about CI/CD and automated testing so pardon me.

@jacobmllr95 jacobmllr95 self-requested a review October 28, 2020 08:05
@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #5965 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5965   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          289       289           
  Lines         9757      9757           
  Branches      2554      2554           
=========================================
  Hits          9757      9757
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/media/media-aside.js 100.00% <100.00%> (ø)
src/components/media/media-body.js 100.00% <100.00%> (ø)
src/components/media/media.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e82e7f...ba1ac73. Read the comment docs.

@jacobmllr95 jacobmllr95 changed the title fix(b-media): removed the usage of utility classes feat(b-media): improve aside right handling Oct 28, 2020
@jacobmllr95 jacobmllr95 added Type: Enhancement PR: Minor Requires minor version bump and removed PR: Patch Requires patch version bump labels Oct 28, 2020
@jacobmllr95 jacobmllr95 merged commit 49a3f00 into bootstrap-vue:dev Oct 28, 2020
@jacobmllr95 jacobmllr95 mentioned this pull request Nov 8, 2020
Merged
@zhnoah
Copy link

zhnoah commented Nov 10, 2020

how to add 'mr-3' class when using aside slot.

@jd-solanki
Copy link
Contributor Author

jd-solanki commented Nov 10, 2020

Hi, @zhnoah mr-3 class is converted into style. You can check the latest docs and inspect the component for new style.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

Assignees

No one assigned

Labels

PR: Minor Requires minor version bump Type: Enhancement Type: Fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jd-solanki @zhnoah @jacobmllr95