Skip to content

[ISSUE #8651] Fix revive topic process lag metric calculation #8652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Sep 5, 2024

Which Issue(s) This PR Fixes

Fixes #8651

Brief Description

Lag is maxQueueOffset plus nextPullOffset

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.75%. Comparing base (0b0f8ec) to head (bc8b319).
Report is 235 commits behind head on develop.

Files with missing lines Patch % Lines
...he/rocketmq/broker/processor/PopReviveService.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8652      +/-   ##
=============================================
+ Coverage      47.26%   50.75%   +3.48%     
- Complexity     11487    14571    +3084     
=============================================
  Files           1277     1344      +67     
  Lines          89432   109452   +20020     
  Branches       11502    16128    +4626     
=============================================
+ Hits           42272    55551   +13279     
- Misses         41953    47605    +5652     
- Partials        5207     6296    +1089     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin reopened this May 13, 2025
@lollipopjin lollipopjin merged commit d59a2dd into apache:develop May 13, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Fix revive topic process lag metric value
3 participants