HTML API: Reliably parse HTML in wp_html_split().
#9270
+181
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
5 times, most recently
from
1410116 to
0440d83
Compare
12 tasks
1 task
|
I believe this would fix https://core.trac.wordpress.org/ticket/45387. |
|
@github-actions why don’t I come in and mess with all of your work unsolicited, huh? |
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
from
0440d83 to
4a0e1a2
Compare
This was referenced Sep 11, 2025
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
from
5fe2dcd to
3f806d8
Compare
dmsnell
commented
Sep 11, 2025
| $regex = get_html_split_regex(); | ||
| $result = benchmark_pcre_backtracking( $regex, $input, 'split' ); | ||
| return $this->assertLessThan( 200, $result ); | ||
| } |
There was a problem hiding this comment.
There is no longer a PCRE used in wp_html_split() and therefore no backtracking.
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
5 times, most recently
from
d319642 to
c5b62b8
Compare
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
3 times, most recently
from
a51cc59 to
8a5805f
Compare
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
3 times, most recently
from
e17de28 to
479b18a
Compare
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
5 times, most recently
from
a52a8f9 to
fcac561
Compare
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
3 times, most recently
from
c06e2c8 to
e4f3798
Compare
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
2 times, most recently
from
ff20347 to
085390b
Compare
Trac ticket: Core-63694 This probably improves the performance in terms of both CPU time and memory compared to the old PCRE-based approach.
Was detecting a non-escaped `<` as the start of an “element” and then replaced a newline in the text as `<!-- wpnl -->` since it thought it was replacing inside a tag. In the end that translated into a raw `\n` again in the end.
dmsnell
force-pushed
the
html-api/refactor-html-split-regex
branch
from
fcb6b14 to
f8a1e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-63694
Replaces #6651
See: (#9270), #9850, #9851
Design feedback
<[[gallery]]>to be an escaped shortcode inside an HTML tag, but HTML considers it plaintext instead of a tag (because the starting character after the initial<is not a letter).a. Is this actually a shortcode inside a tag to be ignored?
b. Is this a shortcode inside a text node?
<[gallery]>and the[gallery]shortcode translated into a tag name then this entire thing would become a tag on replacement.Implementation
This probably improves the performance in terms of both CPU time and memory compared to the old PCRE-based approach.