Block Visibility: show snackbar when hiding block #72027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
|
Size Change: +140 B (+0.01%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 17d0b2c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18209373178
|
|
Nice! Looks good. I guess it needs a quick code gut check. |
t-hamano
added
[Type] Enhancement
ramonjd
approved these changes
Oct 2, 2025
packages/block-editor/src/components/block-visibility/menu-item.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-visibility/menu-item.js
Outdated
Show resolved
Hide resolved
…m.js Co-authored-by: Ramon <[email protected]>
t-hamano
commented
Oct 3, 2025
packages/block-editor/src/components/block-visibility/menu-item.js
Outdated
Show resolved
Hide resolved
|
@jasmussen @ramonjd Thanks for the review! |
t-hamano
commented
Oct 3, 2025
packages/block-editor/src/components/block-visibility/menu-item.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-visibility/menu-item.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Shows a snackbar when hiding the selected block.
Screenshots in Windows OS: The shortcut key should be
⌃⌥Oin MacOSWhy?
When the Hide button is clicked, the selected block is visually hidden, and users may not know how to enable the block again.
How?
One problem may be that this snackbar will be displayed even when the block is hidden via the List View. This is because the same options dropdown component is used in both the List View and the block toolbar. I'm a bit hesitant to do this because it would likely require changing the behavior of public components.
Testing Instructions
Hide a block and confirm the snackbar.
Screenshots or screencast
4ae12de94dff9f57c3f99a915be14e70.1.mp4