Add Big-O time and space complexity comments for sorting algorithms #7155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeahl
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7155 +/- ##
=========================================
Coverage 78.61% 78.61%
Complexity 6824 6824
=========================================
Files 766 766
Lines 22607 22607
Branches 4444 4444
=========================================
Hits 17773 17773
Misses 4119 4119
Partials 715 715 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
approved these changes
Dec 10, 2025
Member
DenizAltunkapan
left a comment
DenizAltunkapan
left a comment
There was a problem hiding this comment.
Thank you for your contribution @codeahl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds time and space complexity documentation to several sorting algorithm implementations in the repository. The following changes were made:
BubbleSort – Added best, average, and worst-case time complexity (O(n²)) and space complexity (O(1)) comments.
MergeSort – Added time complexity (O(n log n)) and space complexity (O(n)) comments.
QuickSort – Added best, average (O(n log n)), and worst-case (O(n²)) time complexity and space complexity (O(log n) recursive stack) comments.
SelectionSort – Added time complexity (O(n²)) and space complexity (O(1)) comments.
InsertionSort – Added time complexity (best: O(n), worst: O(n²)) and space complexity (O(1)) comments.
HeapSort – Added time complexity (O(n log n)) and space complexity (O(1)) comments.
TopologicalSort – Added comments describing the DFS approach, linear ordering of DAGs, and complexity (time: Θ(V + E), space: O(V + E)).
More comments will be needed however, to make time/space complexity clearer for the other algorithms.
Fixes #7123