Skip to content

fix: windows 下开启CompileMode报错 (#15252) #17583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhang0ZGC
Copy link

@zhang0ZGC zhang0ZGC commented Apr 21, 2025

这个 PR 做了什么? (简要描述所做更改)
windows 系统下开启 CompileMode 编译代码后, *-templates.wxml 文件中引用文件的路径错误,开发者工具无法识别到文件,在此规范化文件路径

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix 开启半编译模式 —— CompileMode报错 #15252
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Summary by CodeRabbit

  • 修复问题
    • 规范化生成的路径格式,提升跨平台兼容性,避免路径分隔符不一致导致的问题。

Copy link

coderabbitai bot commented Apr 21, 2025

Walkthrough

本次更改在 MiniCompileModePlugin 插件的 processAssets 钩子中,引入了 normalizePath 方法,并用其对通过 path.relative 生成的路径进行规范化。具体来说,涉及 XML import 语句和 template.buildXsImportTemplate 调用中的路径,均被 normalizePath 包裹,以保证路径格式一致(如统一为正斜杠)。除此之外,未修改其他逻辑、控制流或错误处理。

Changes

文件/路径 变更摘要
packages/taro-webpack5-runner/src/plugins/MiniCompileModePlugin.ts 引入 normalizePath,并用于规范化 path.relative 生成的路径

Assessment against linked issues

Objective Addressed Explanation
修复开启半编译模式 CompileMode 路径报错问题 (#15252)

Poem

兔子挥爪理路径,
斜杠横跨无畏惧。
Windows、Linux皆顺畅,
编译模式不再哭。
路径规范皆如意,
代码世界乐无比!
 /|、
( •.•)
/   づ

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/taro-webpack5-runner/src/plugins/MiniCompileModePlugin.ts (1)

301-302: 对 XS 导入路径同样进行标准化
template.buildXsImportTemplate 前使用 normalizePath(path.relative(...)),保证生成的 xs 导入路径跨平台一致。建议将 path.dirname(key)path.relative 的组合提取为内部小函数以减少冗余。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac2dfa4 and 7ed838b.

📒 Files selected for processing (1)
  • packages/taro-webpack5-runner/src/plugins/MiniCompileModePlugin.ts (2 hunks)
🔇 Additional comments (2)
packages/taro-webpack5-runner/src/plugins/MiniCompileModePlugin.ts (2)

299-299: 对基础模板导入路径应用标准化
<import src="..."/> 中对 path.relative 结果调用 normalizePath,确保 Windows 下的反斜杠被转换为正斜杠,从而解决文件路径识别失败的问题。


30-30:

✅ Verification successful

导入 normalizePath
已正确从 @tarojs/helper 导入 normalizePath,建议确认该依赖是否已在 package.json 中声明以避免构建时缺失。


🏁 Script executed:

#!/bin/bash
# 验证 @tarojs/helper 是否已在 package.json 中列出
grep -R "\"@tarojs/helper\"" -n package.json

Length of output: 44


🏁 Script executed:

#!/bin/bash
# 在整个仓库的所有 package.json 文件中查找是否声明了 @tarojs/helper
grep -R '"@tarojs/helper"' -n .

Length of output: 13506


依赖已在 package.json 中声明,无需修改
已在 packages/taro-webpack5-runner/package.json(第 36 行)以 workspace:* 方式声明 @tarojs/helper,验证通过。

This was referenced Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

开启半编译模式 —— CompileMode报错
1 participant