fix[testVueSdk]: try to not use a global isolate instance and create fresh instance for each request #4210
+82
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…memory leaks - Removed global IVM_CONTEXT and related functions to ensure isolates are created anew for each request. - Updated `setIvm` to utilize options per request instead of globally. - Enhanced `runInNode` to initialize the isolate and context directly within the function, improving memory management and cleanup. - Added comments to clarify changes and rationale for the new approach. This refactor aims to enhance performance and reliability by eliminating potential memory leaks associated with persistent isolates.
…roved memory management - Added `IVM_OPTIONS` to store isolate options, defaulting to a memory limit of 128. - Updated `setIvm` to accept and store options for each request, enhancing flexibility. - Modified `runInNode` to utilize stored options when creating isolates, ensuring consistent memory management. - Improved comments for clarity on the new approach and its benefits. This refactor aims to further optimize memory usage and isolate management in the node runtime.
|
|
View your CI Pipeline Execution ↗ for commit 6c588e5
☁️ Nx Cloud last updated this comment at |
- Eliminated the unused `Context` import from `isolated-vm` in the node-runtime file. - This change simplifies the code and improves readability by removing unnecessary dependencies. This refactor contributes to maintaining a clean and efficient codebase.
floating-dynamo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Strategy:
This guarantees memory cleanup because the entire memory block is freed by C++.
Screenshot
If relevant, add a screenshot or two of the changes you made.
Note
Switches Node evaluate runtime to create and dispose a fresh
isolated-vmper request, removing the global context and allowing configurable isolate options.packages/sdks/src/functions/evaluate/node-runtime/node-runtime.ts):ivm.Isolateper call inrunInNodeand dispose it infinally.Context/singleton isolate management (setIsolateContext/getIsolateContext).setIvmto accept optionalIsolateOptionsand store them inIVM_OPTIONSfor per-request use.log,BUILDER_IVM) insiderunInNode; keep state propagation viaBUILDER_SET_STATEand argument proxying unchanged.Written by Cursor Bugbot for commit 6c588e5. This will update automatically on new commits. Configure here.