now I wish to add full information of entity, I am facing diffuculty on that Mr_Monkey
alastairp
e.g. urlunparse(('hdfs', 'hadoop-master:9000', os.path.join(path.DATAFRAME_DIR, 'filename')))
but I don't think that this is clearer to understand. I think it would be fine to use os.path.join for the paths, and then join the url and path with +
Mr_Monkey
What's the issue?
alastairp
I think that each command that you run should create the directories that it needs before it runs
akhilesh
at `api/helpers/utils.js` I wish to load entity detail at line 67, but unable to pass orm from this place, means from the .map Mr_Monkey
pristine__
alastairp: you mean, before running any script I should create all the req directories in HDFS?
alastairp
if a command needs path.DATAFRAME_DIR, create it at the beginning of that command
does the command to create a directory in hdfs fail if the directory already exists?
does the operation take a long time, or is it quite quick?
Mr_Monkey
akhilesh: Do you need the ORM there? I think the `getEntityInfoMethod` parameter you call the
I created manage.py to create all the required directories in hdfs. There are three scripts, all of which need different directories, earlier I was creating these dir in the script itself. But then I thought of centralizing it so I made manage.py. not sure if it is a good idea. No, if the dir already exists, nothing is happening, it will create a new if it does not exit.
The operation is quick. Not an overhead
Mr_Monkey
akhilesh: I think it's as simple as doing `entity: getEntityInfoMethod(relationship.target),` and same for relationship.source a few line slower
Let me try it out
pristine__
Exist*
alastairp: ^
akhilesh
pass orm also with loadEntity function Mr_Monkey
alastairp
if it's low overhead then I'd just do it every time
because you don't want to have a situation where you run a 3 hour job and then it fails just because you forgot to run a different command first
pristine__
ruaok: ^
Okay
akhilesh
`getEntityInfoMethod` does only formating of data, `relationship.target` does not have full data of entity Mr_Monkey
Mr_Monkey
akhilesh: Then you probably want to load more related data in `loadEntityRelationshipsForBrowse`
I'll give it a quick try
pristine__
alastairp: one more thing. Since I am a beginner, I am not so good at writing beautiful code. These three scripts, it will great if you could just have a look and suggest me things. Like whenever you are free. I can create another gist for an overview.
akhilesh
that is also good option but how to load more data at `loadEntityRelationshipsForBrowse` Mr_Monkey , take a look on it and help please
pristine__
If you are okay with it.
:)
akhilesh
`loadEntity` funtion also written at line 102, in middleware.js , help call this some how for each relationship Mr_Monkey , for source and target both
alastairp
yeah, that's fine. you're welcome to request a review from me on PRs
Darkloke has quit
pristine__
<3
chaban joined the channel
Mr_Monkey
akhilesh: Just pushed some code for browse relationships that should get you going. ORM passed to `getBrowsedRelationships` properly (from req.app.locals, not res.locals), and fetching the entities in the same method.
gr0uch0mars joined the channel
akhilesh
Yes, I am looking that code Mr_Monkey
Mr_Monkey
I'll be back in a bit
akhilesh
Going?
Mr_Monkey
Here but doing other things
rdswift joined the channel
akhilesh
Mr_Monkey: I have two more queries, free?
chaban has quit
amCap1712
hi gr0uch0mars
gr0uch0mars
Hi amCap1712
How are u doing the last week?
amCap1712
doing well
most of the work on initial tagger is complete
gr0uch0mars: will most probably merge the pr today
gr0uch0mars
Glad to hear that!
amCap1712
i have released couple of updates for testing
CatQuest: has tested the tagger and i have refined some of it parts
CatQuest
sounds good!
gr0uch0mars
👏🏻
amCap1712
the metadata lookup is acting strangely will work on fixing it
hows your trip going?
also since the final evals open up later today
CatQuest
:o
amCap1712
i wanted to ask how should i submit my work?
gr0uch0mars: the work submission guidelines say i should discuss with the mentor on how to submit the work
a blog post, github readme or what?
CatQuest
gr0uch0mars: ping
Mr_Monkey
akhilesh: You're always encouraged to post the questions even if I'm not here, and I can answer when I'm free
gr0uch0mars
I think, reading the guidelines, that your Github repo is fine. Add a good README.md at the root so what has been done and what is left is clear to anyone.
Remember: the goal is not only to make it work, but to make a good Open Source code: write a good documentation, good code comments, what is left (in case anybody wants to collaborate)…
amCap1712
yeah sure
gr0uch0mars
amCap1712: I arrive at home this Saturday afternoon. Then I’ll make sure the code compiles and some basic testing
Just to given you some (deserved) feedback on your work 🙂
amCap1712
that would be great
ruaok
Freso: sorry can't make the meeting. Limited connectivity, slightly tricky circumstances.
My review: PRs. Background meb stuff. Conversations with Microsoft, not too much work. I hope to make it next week.
oknozor joined the channel
oknozor has quit
akhilesh
Mr_Monkey: Request validator written at middleware.js are not the exact validator, Those are only for basic use. First questions, what are the exact and valid URLs for browse request? how to validate query params passed in these requests like multiple bbid, any other unrelated params? What will be the response if invalid params? It is very helpful if you will explain one browse request and with one
browseRequestValidator function. You may respond on PR itself. Sorry for all the mistakes.
People up for reviews: yvanzo, ruaok, zas, Mr_Monkey, iliekcomputers, reosarevok, bitmap, Freso, akhilesh, spellew, pristine__, aidanlw17, Cyna, amCap1712, CatQuest – anyone else, please let me know explicitly ASAP.
yvanzo: Go!
yvanzo says:
"""
Last week, I continued to work on MB dockerization with new search.
Released and deployed a new SIR, fixing regressions only.
Started to test MB/SIR/SOLR in a new Azure VM.
Pushed a new branch for early testers of musicbrainz-docker: mbvm-38-dev
Also, MB Server has a new beta, getting back to the 2 weeks release cycle!
Plus PRs review and community support (incl. reupload of MB VM on FTP).
"""
ruaok: Go!
ruaok says:
"""
PRs. Background meb stuff. Conversations with Microsoft, not too much work. I hope to make it next week.
CatQuest
\o
Freso
"""
zas: Go!
zas
Hey
CatQuest
hi!
zas
Nothing fancy but usual stuff
We had few network issues yesterday, but not under our control
I upgraded grafana and all systems
Also done quite a lot Picard code reviews (thanks to phw) :)
fin. yvanzo ?
Mr_Monkey ?
Mr_Monkey
Helo !
Well, another slow and hot week, but I dutifully continued reviewing the API GSOC project. Glad to say it's moving along !
Some minimal repo upkeep and dependency updates as well.
That's all folks !
CatQuest: go !
CatQuest
Meow! `😺`
Have worked quite a lot adding aliases and disambiguating glockenspiel(carillon in french) from carillon (glockenspiel/klokkespill in germanic languages) from music box (carillon(s) in italian) and chimes (general) from carillon (sometimes called chimes) from tubular bells (Orchestra bells/chimes in some slav languages) from finally back to glockenspiel again ( i.e. INST-809 & INST-825 (which is where this entire round-robin originally st
