COLLECTED BY
Web crawl data from Common Crawl.
The Wayback Machine - https://web.archive.org/web/20210919071731/https://lua-users.org/lists/lua-l/2010-06/msg00477.html
[Date Prev][Date Next][Thread Prev][Thread Next]
[Date Index]
[Thread Index]
- Subject: Re: redundant gkey and key2tval in ltable.h (5.2.0-work3)
- From: HyperHacker <hyperhacker@...>
- Date: Wed, 23 Jun 2010 23:01:45 -0600
On Wed, Jun 23, 2010 at 22:25, David Manura <[email protected]> wrote:
> On Thu, Jun 24, 2010 at 12:13 AM, David Manura <[email protected]> wrote:
>> Any reason not to eliminate key2tval(n) ?
>
> BTW, I would prefer some minimal comments in the source about macro
> parameter types, maybe like this:
>
> �/* t:Table*, i:int, n:Node*. */
> �#define gnode(t,i) � �(&(t)->node[i])
> �#define gkey(n) � � � (&(n)->i_key.tvk)
> �#define gval(n) � � � � � � � (&(n)->i_val)
> �#define gnext(n) � � �((n)->i_key.nk.next)
>
I would say the source needs a lot more comments overall.
--
Sent from my toaster.
