Vector should not direct third-party wikis to report dark mode issues to MW.o
Open, MediumPublic3 Estimated Story PointsBUG REPORT
Actions

Description

	"vector-night-mode-issue-reporting-notice-url": "https://www.mediawiki.org/wiki/Reading/Web/Accessibility_for_reading/Reporting/$1?section=new&action=submit&preloadtitle=$2&preload=MediaWiki:vector-night-mode-issue-reporting-preload-content",

This should not default to a mediawiki.org page for non-Wikimedia wikis.

/cc @Jdrewniak @Jdlrobson-WMF, seems like this was introduced in T367871.

Requirements

Move vector-night-mode-issue-reporting-notice-url from Vector skin to WikimediaMessages
Set default message in Vector to empty string.

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/ (desktop) login and select dark mode. Under dark mode is a link to report issue. Click it
Click to report issue should take you to the MediaWiki.org

Details

	Subject	Repo	Branch	Lines +/-
	adds night-mode-reporting-url in wikimediamessages	mediawiki/extensions/WikimediaMessages	master	+1 -0
	set the default url to an empty string	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T367871: Create link for reporting system for dark mode issues

Event Timeline

taavi created this task.Feb 6 2025, 3:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2025, 3:41 PM

taavi changed the subtype of this task from "Task" to "Bug Report".Feb 6 2025, 3:41 PM

Jdlrobson added a project: Web-Team.Feb 6 2025, 3:46 PM

Jdlrobson-WMF triaged this task as Low priority.Feb 6 2025, 4:57 PM

Jdlrobson-WMF moved this task from Incoming to Q3 on the Web-Team board.

Jdlrobson-WMF moved this task from Incoming to Groomed on the Vector 2022 (Desktop improvements) board.Feb 6 2025, 10:47 PM

Jdlrobson-WMF added a project: WikimediaMessages.Feb 10 2025, 6:26 PM

Jdlrobson-WMF updated the task description. (Show Details)

Jdlrobson-WMF added projects: patch-welcome, good first task.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

yikes, this isn't behind a WMF-only flag ?

@ovasileva we seem to be getting reports from miraheze wiki https://www.mediawiki.org/wiki/Reading/Web/Accessibility_for_reading/Reporting so recommend we bump priority.

I'll start an estimation thread.

Jdlrobson-WMF set the point value for this task to 3.Feb 13 2025, 11:56 PM

Jdlrobson-WMF moved this task from Q3 to Sprint Backlog on the Web-Team board.

Jdlrobson-WMF moved this task from Sprint Backlog to Q3 on the Web-Team board.Feb 19 2025, 6:37 PM

Jdlrobson-WMF changed the task status from In Progress to Open.Feb 24 2025, 6:50 PM

Jdlrobson-WMF moved this task from Q3 to Sprint Backlog on the Web-Team board.Feb 27 2025, 6:46 PM

Reedy added a project: affects-Miraheze.Feb 27 2025, 9:49 PM

Filed upstream in https://issue-tracker.miraheze.org/T13285 and reported on their discord server.

Hoping to get a fix out for this in next 1-3 weeks (hopefully!).

Jdlrobson-WMF moved this task from Sprint Backlog to Q3 on the Web-Team board.Mar 5 2025, 6:54 PM

Change #1132001 had a related patch set uploaded (by ParvC; author: ParvC):

[mediawiki/extensions/WikimediaMessages@master] adds night-mode-reporting-url in wikimediamessages T385811

https://gerrit.wikimedia.org/r/1132001

gerritbot added a project: Patch-For-Review.Mar 28 2025, 4:59 PM

I have submitted two patches since this fix involves changes in two separate repositories: WikimediaMessages and Vector skin. However, only the first patch appears here. here is the link to second one
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1131999

Change #1132001 had a related patch set uploaded (by Jdlrobson; author: ParvC):

[mediawiki/extensions/WikimediaMessages@master] adds night-mode-reporting-url in wikimediamessages

https://gerrit.wikimedia.org/r/1132001

Change #1131999 had a related patch set uploaded (by Jdlrobson; author: ParvC):

[mediawiki/skins/Vector@master] set the default url to an empty string

https://gerrit.wikimedia.org/r/1131999

Jdlrobson-WMF updated the task description. (Show Details)Mar 28 2025, 6:44 PM

Jdlrobson-WMF moved this task from Q3 to Q4 on the Web-Team board.Apr 3 2025, 6:38 PM

A_smart_kitten added a project: MW-1.44-release.Mon, May 19, 12:53 PM

A_smart_kitten subscribed.

@ParvC are you still interested in helping us get this fixed? Would be great to get this addressed and your patch was close! No worries if not, just let us know so we can let somebody else work on it. Thanks in advance!

Vector should not direct third-party wikis to report dark mode issues to MW.oOpen, MediumPublic3 Estimated Story PointsBUG REPORTActions