Skip to content

feat: update Windows shortcut name #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

stevenjoezhang
Copy link
Contributor

目前clash-verge-rev在Windows上通过安装包安装完成后,创建的桌面和开始菜单快捷方式名称为clash-verge。这个Pull Request将其修改为了Clash Verge,作为桌面图标的名称更优雅一些。

@wonfen
Copy link
Member

wonfen commented Mar 12, 2025

有测试过改过来会带来其他问题吗?之前是从Clash Verge 故意改为 clash-verge 的。修改原因忘了
比如杀毒软件报毒,升级安装、覆盖安装、更新版本后导致2个图标,自启动启动多次等情况

@stevenjoezhang stevenjoezhang marked this pull request as draft March 13, 2025 02:13
@stevenjoezhang
Copy link
Contributor Author

@wonfen 谢谢提醒,我之前简单的测试了安装和卸载,快捷方式的创建、删除没有遇到问题。
我找到了一个相关的 Pull Request: #273 ,似乎在创建 scripts/windows/installer.nsi 这个文件的时候就用的是 ${MAINBINARYNAME}.lnk,后来也没有修改,图标、自启动这些可能是其它代码的问题?我再多测试一下看看

@stevenjoezhang
Copy link
Contributor Author

@wonfen 我在Windows 10 和11上测试了:

  • 安装2.1.2稳定版本,然后重新安装改动后的最新构建版本
  • 安装改动后的最新构建版本,然后重新安装2.1.2稳定版本

都没有遇到问题,旧图标可以在卸载时正常删除。自启动也没有问题,快捷方式名称似乎也不会影响自启动。报毒的话比较玄学,Windows Defender没啥问题,其他杀毒软件我没有测试。

@Tunglies Tunglies force-pushed the dev branch 2 times, most recently from f586285 to abe0750 Compare March 20, 2025 11:11
Copy link

@DadFall DadFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Tunglies Tunglies force-pushed the dev branch 4 times, most recently from 4e0a882 to 52f9832 Compare March 25, 2025 17:51
@wonfen wonfen force-pushed the dev branch 3 times, most recently from 1024402 to a2a6c54 Compare March 31, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants