Add jshint task in gulpfile and lint all js files

imor · imor · commit d0bcd9ee340f · 2015-01-06T09:55:26.000+05:30
diff --git a/gulpfile.js b/gulpfile.js
@@ -5,7 +5,9 @@ var gulp = require('gulp'),
     concat = require('gulp-concat'),
     mocha = require('gulp-mocha'),
     shell = require('gulp-shell'),
-    del = require('del');
+    del = require('del'),
+    jshint = require('gulp-jshint'),
+    stylish = require('jshint-stylish');
 
 gulp.task('clean', function(cb) {
     del('lib/**/*.*', cb);
@@ -44,5 +46,12 @@ gulp.task('bench', shell.task([
     'node benchmark/benchmark.js'
 ]));
 
-gulp.task('default', ['test', 'compile'], function() {
+gulp.task('lint', function() {
+  return gulp.src('./src/**/*.js')
+    .pipe(jshint())
+    .pipe(jshint.reporter(stylish))
+    .pipe(jshint.reporter('fail'));
+});
+
+gulp.task('default', ['lint', 'test', 'compile'], function() {
 });
diff --git a/package.json b/package.json
@@ -23,10 +23,12 @@
     "gulp": "^3.8.10",
     "gulp-browserify": "^0.5.0",
     "gulp-concat": "^2.4.1",
+    "gulp-jshint": "^1.9.0",
     "gulp-mocha": "^2.0.0",
     "gulp-rename": "^1.2.0",
     "gulp-shell": "^0.2.10",
     "gulp-uglify": "^1.0.1",
+    "jshint-stylish": "^1.0.0",
     "mocha": "2.0.x",
     "should": "4.3.x"
   },
diff --git a/src/core/Node.js b/src/core/Node.js
@@ -23,6 +23,6 @@ function Node(x, y, walkable) {
      * @type boolean
      */
     this.walkable = (walkable === undefined ? true : walkable);
-};
+}
 
 module.exports = Node;
diff --git a/src/finders/BestFirstFinder.js b/src/finders/BestFirstFinder.js
@@ -18,7 +18,7 @@ function BestFirstFinder(opt) {
     this.heuristic = function(dx, dy) {
         return orig(dx, dy) * 1000000;
     };
-};
+}
 
 BestFirstFinder.prototype = new AStarFinder();
 BestFirstFinder.prototype.constructor = BestFirstFinder;
diff --git a/src/finders/IDAStarFinder.js b/src/finders/IDAStarFinder.js
@@ -127,8 +127,10 @@ IDAStarFinder.prototype.findPath = function(startX, startY, endX, endY, grid) {
         //    return h(a, end) - h(b, end);
         //});
 
+        
+        /*jshint -W084 *///Disable warning: Expected a conditional expression and instead saw an assignment
         for(k = 0, min = Infinity; neighbour = neighbours[k]; ++k) {
-
+        /*jshint +W084 *///Enable warning: Expected a conditional expression and instead saw an assignment
             if(this.trackRecursion) {
                 // Retain a copy for visualisation. Due to recursion, this
                 // node may be part of other paths too.
diff --git a/src/finders/JPFMoveDiagonallyIfNoObstacles.js b/src/finders/JPFMoveDiagonallyIfNoObstacles.js
@@ -114,8 +114,9 @@ JPFMoveDiagonallyIfNoObstacles.prototype._findNeighbors = function(node) {
         }
         // search horizontally/vertically
         else {
+            var isNextWalkable;
             if (dx !== 0) {
-                var isNextWalkable = grid.isWalkableAt(x + dx, y);
+                isNextWalkable = grid.isWalkableAt(x + dx, y);
                 var isTopWalkable = grid.isWalkableAt(x, y + 1);
                 var isBottomWalkable = grid.isWalkableAt(x, y - 1);
 
@@ -136,7 +137,7 @@ JPFMoveDiagonallyIfNoObstacles.prototype._findNeighbors = function(node) {
                 }
             }
             else if (dy !== 0) {
-                var isNextWalkable = grid.isWalkableAt(x, y + dy);
+                isNextWalkable = grid.isWalkableAt(x, y + dy);
                 var isRightWalkable = grid.isWalkableAt(x + 1, y);
                 var isLeftWalkable = grid.isWalkableAt(x - 1, y);
 

Original file line number	Diff line number	Diff line change
`@@ -114,8 +114,9 @@ JPFMoveDiagonallyIfNoObstacles.prototype._findNeighbors = function(node) {`
`114`	`114`	`}`
`115`	`115`	`// search horizontally/vertically`
`116`	`116`	`else {`
	`117`	`+ var isNextWalkable;`
`117`	`118`	`if (dx !== 0) {`
`118`		`- var isNextWalkable = grid.isWalkableAt(x + dx, y);`
	`119`	`+ isNextWalkable = grid.isWalkableAt(x + dx, y);`
`119`	`120`	`var isTopWalkable = grid.isWalkableAt(x, y + 1);`
`120`	`121`	`var isBottomWalkable = grid.isWalkableAt(x, y - 1);`
`121`	`122`
`@@ -136,7 +137,7 @@ JPFMoveDiagonallyIfNoObstacles.prototype._findNeighbors = function(node) {`
`136`	`137`	`}`
`137`	`138`	`}`
`138`	`139`	`else if (dy !== 0) {`
`139`		`- var isNextWalkable = grid.isWalkableAt(x, y + dy);`
	`140`	`+ isNextWalkable = grid.isWalkableAt(x, y + dy);`
`140`	`141`	`var isRightWalkable = grid.isWalkableAt(x + 1, y);`
`141`	`142`	`var isLeftWalkable = grid.isWalkableAt(x - 1, y);`
`142`	`143`