fix(cli): validate init port option

Nik Samokhvalov · Nik Samokhvalov · commit f52c59db0357 · 2025-12-13T07:57:38.000-08:00
- Reject non-numeric or out-of-range ports for psql-like -p/--port

- Add unit test for invalid port
diff --git a/cli/lib/init.ts b/cli/lib/init.ts
@@ -195,7 +195,13 @@ export function resolveAdminConnection(opts: {
 
   const cfg: PgClientConfig = {};
   if (opts.host) cfg.host = opts.host;
-  if (opts.port !== undefined && opts.port !== "") cfg.port = Number(opts.port);
+  if (opts.port !== undefined && opts.port !== "") {
+    const p = Number(opts.port);
+    if (!Number.isFinite(p) || !Number.isInteger(p) || p <= 0 || p > 65535) {
+      throw new Error(`Invalid port value: ${String(opts.port)}`);
+    }
+    cfg.port = p;
+  }
   if (opts.username) cfg.user = opts.username;
   if (opts.dbname) cfg.database = opts.dbname;
   if (opts.adminPassword) cfg.password = opts.adminPassword;
diff --git a/cli/test/init.test.cjs b/cli/test/init.test.cjs
@@ -66,4 +66,11 @@ test("resolveAdminConnection accepts positional conninfo", () => {
   assert.equal(r.clientConfig.user, "alice");
 });
 
+test("resolveAdminConnection rejects invalid psql-like port", () => {
+  assert.throws(
+    () => init.resolveAdminConnection({ host: "localhost", port: "abc", username: "u", dbname: "d" }),
+    /Invalid port value/
+  );
+});
+
 
