GitHub Community
Users can now choose whether merging linked pull requests automatically closes the issue #157378
Replies: 16 comments 14 replies
-
|
Thank you @tuves & team! What a great feature. Is it possible to enable this on an organizational level by default? JFYI the image is broken, seems like it's possibly linking to a previously uploaded image on a private repository. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @alexwilson1, image has been fixed! |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
whether this feature can be enabled on the org level? |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for implementing this! Any idea when this will be available in GitHub enterprise? |
Beta Was this translation helpful? Give feedback.
-
|
We will aim to have this ready as part of GHES 3.18. |
Beta Was this translation helpful? Give feedback.
-
|
This sounds like a very useful addition, Will there be any visual indication on the issue or PR that it's linked but won't auto-close upon merge? |
Beta Was this translation helpful? Give feedback.
-
|
Not currently, but that is an idea we can explore. Thanks for the feedback! |
Beta Was this translation helpful? Give feedback.
-
|
Great news. I couldn't find documentation in the REST nor GraphQL API, will something be done on that front? (i.e. if we need to change that setting on 100s of repositories). Thanks |
Beta Was this translation helpful? Give feedback.
-
|
That is something we're looking to bring in the coming weeks. Stay tuned! |
Beta Was this translation helpful? Give feedback.
-
|
Has there been any progress made on toggling this feature over the API? |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Thank you, but it should not have taken years and thousands of complaints to offer this feature. Even still, it's not yet in GH Enterprise where the primary audience for this feature exists. |
Beta Was this translation helpful? Give feedback.
-
|
What might make this much more useful is a choice of a "release" branch which is separate from the default branch, and then more in-line with the git-flow branching model (default being both are the same branch). In that scenario, PRs would automatically target the default branch as they do now, but issues won't be closed until the PR eventually gets merged into the release branch. Although this change here allows that to happen manually, it leaves you with a more manual process to close issues that will likely end with that bit being forgotten, and hard to trace. |
Beta Was this translation helpful? Give feedback.
-
|
I think that you can already do this by just changing your default branch to your release branch, then the existing behaviour (before this new feature was released) would work as you want it. |
Beta Was this translation helpful? Give feedback.
-
|
That is true, but then the default branch is where PRs will automatically be opened against as I understand it. That means you have to choose between having PRs open against the correct branch by default, or issues being closed by PRs by default. I understand that both of these are easy to fix manually (especially in light of this new feature), but also know that when these things are not the default behaviour, they will go wrong at some point! |
Beta Was this translation helpful? Give feedback.
-
|
Does this affect It would be desirable to differentiate between |
Beta Was this translation helpful? Give feedback.
-
|
This feature is not working properly, or it only works with issues linked in the default branch |
Beta Was this translation helpful? Give feedback.
-
|
This is by design:
|
Beta Was this translation helpful? Give feedback.
-
|
This important opt out information is not included in https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue, please add at the top/beginning. |
Beta Was this translation helpful? Give feedback.
-
|
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue still is missing any information on how to opt out of this unwanted auto closing feature! How hard is it to update a documentation page? |
Beta Was this translation helpful? Give feedback.
-
|
With this option turned off, I cannot get issues to close automatically, when a linked PR is merged. I added "Closes #..." to the description of the PR, but it does not work. |
Beta Was this translation helpful? Give feedback.
-
|
Agreed, this is not what I thought the intention of this was. It should not autoclose but keywords should still work |
Beta Was this translation helpful? Give feedback.
-
|
It sounds like what you wanted was option 3 here: But as you can see there a large majority of people voted for option 1... I'm not sure if they're still thinking of working on option 2 or 3, or if you'd need to gather support again to convince them to make another change. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Linking a pull request to an issue makes it easy for collaborators to see that work for the issue is underway. Today, when a linked pull request is merged, the associated issue is automatically closed.
But for many teams, merging a PR doesn’t mean the work is done—there might be QA, validation, or follow-up steps before an issue is truly resolved. With this new repository setting, you can choose whether merging a pull request should automatically close its linked issues.
Repository admins and maintainers can manage this setting under Repository settings → General → Issues. It's enabled by default to preserve existing behavior.
This ship addresses one of our most popular Community requests--thank you for your feedback and helping make our products better together 🚀
Beta Was this translation helpful? Give feedback.
All reactions