Tests: Add tests for jQuery.get( String, null-ish, null-ish, String )

mgol · web-flow · commit 76687566f056 · 2025-03-31T18:09:35.000+02:00
Also, fix `mock.php` formatting to not fail the `jQuery.get( String, null, String )` test in PHP mode. Closes gh-5640 Ref gh-4989 Ref jquery/api.jquery.com#1208
diff --git a/test/data/mock.php b/test/data/mock.php
@@ -95,9 +95,9 @@ protected function json( $req ) {
 		}
 
 		if ( isset( $req->query['array'] ) ) {
-			echo '[ {"name": "John", "age": 21}, {"name": "Peter", "age": 25 } ]';
+			echo '[{"name":"John","age":21},{"name":"Peter","age":25}]';
 		} else {
-			echo '{ "data": {"lang": "en", "length": 25} }';
+			echo '{"data":{"lang":"en","length":25}}';
 		}
 	}
 
diff --git a/test/unit/ajax.js b/test/unit/ajax.js
@@ -2782,7 +2782,7 @@ if ( typeof window.ArrayBuffer === "undefined" || typeof new XMLHttpRequest().re
 		} );
 	} );
 
-	QUnit.test( "jQuery.get( String, null-ish, String ) - dataType with null callback (gh-4989)",
+	QUnit.test( "jQuery.get( String, null, String ) - dataType with null callback (gh-4989)",
 			function( assert ) {
 		assert.expect( 2 );
 		var done = assert.async( 2 );
@@ -2802,6 +2802,37 @@ if ( typeof window.ArrayBuffer === "undefined" || typeof new XMLHttpRequest().re
 			} );
 	} );
 
+	QUnit.test( "jQuery.get( String, null-ish, null-ish, String ) - dataType with null/undefined  data & callback",
+			function( assert ) {
+		assert.expect( 8 );
+		var done = assert.async( 8 );
+
+		[
+			{ data: null, success: null },
+			{ data: null, success: undefined },
+			{ data: undefined, success: null },
+			{ data: undefined, success: undefined }
+		].forEach( function( options ) {
+			var data = options.data,
+				success = options.success;
+			jQuery.get( url( "mock.php?action=json&header" ), data, success, "json" )
+				.then( function( json ) {
+					assert.deepEqual( json, { data: { lang: "en", length: 25 } },
+						"`dataType: \"json\"` applied with `" + data + "` data & `" +
+						success + "` success callback" );
+					done();
+				} );
+
+			jQuery.get( url( "mock.php?action=json&header" ), null, "text" )
+				.then( function( text ) {
+					assert.strictEqual( text, "{\"data\":{\"lang\":\"en\",\"length\":25}}",
+						"`dataType: \"text\"` applied with `" + data + "` data & `" +
+						success + "` success callback" );
+					done();
+				} );
+		} );
+	} );
+
 //----------- jQuery.getJSON()
 
 	QUnit.test( "jQuery.getJSON( String, Hash, Function ) - JSON array", function( assert ) {

Original file line number	Diff line number	Diff line change
`@@ -95,9 +95,9 @@ protected function json( $req ) {`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`if ( isset( $req->query['array'] ) ) {`
`98`		`- echo '[ {"name": "John", "age": 21}, {"name": "Peter", "age": 25 } ]';`
	`98`	`+ echo '[{"name":"John","age":21},{"name":"Peter","age":25}]';`
`99`	`99`	`} else {`
`100`		`- echo '{ "data": {"lang": "en", "length": 25} }';`
	`100`	`+ echo '{"data":{"lang":"en","length":25}}';`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`