Replies: 5 comments 1 reply
-
|
I'll add the port number to the example and mention it in the wiki. In the note we can mention it as optional, like |
Beta Was this translation helpful? Give feedback.
-
|
PR: #3372 |
Beta Was this translation helpful? Give feedback.
-
|
OK, thanks. How about account_aor()? Why does it include port, but not uri-params? I my opinion, port could be left out. |
Beta Was this translation helpful? Give feedback.
-
|
The reason is that static function User and port number are not directly security related. This information can be useful to identify the right UA for the user and we should not remove it from the AOR. Adding URI-parameters now to the AOR might be a security problem. For the transport protocol this might not be the case, but it can be anything. So I am not sure. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the explanation, but I'm still wondering what the purpose of :port is. How is it related to sip_listen :port? What happens if those two ports do not match? |
Beta Was this translation helpful? Give feedback.
-
|
Whereas, the account port is the remote listen port of the SIP registrar and used as target port for sending the REGISTER. |
Beta Was this translation helpful? Give feedback.
-
Wiki Account page https://github.com/baresip/baresip/wiki/Accounts does not really define the syntax of account line in accounts file. It just gives an example:
That example is at least lacking possibility to include
:portafterdomain. Should the port be included in the example or better yet, could the example be turned into syntax?Then, for example, if I have account line
account_aor()API call returnssip::[email protected]:5080and thus leaves out;transportparameter. What is the logic here?RFC 3261 tells:
In my opinion if port is included then also transport should be included.
Beta Was this translation helpful? Give feedback.
All reactions