perf(common): use ngDevMode to tree-shake warnings (#39964)

arturovt · mhevery · commit bf3de9bcc982 · 2020-12-04T16:11:47.000-08:00
This commit adds ngDevMode guard to show warnings only in dev mode (similar to how things work in other parts of Ivy runtime code). The ngDevMode flag helps to tree-shake these warnings from production builds (in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
diff --git a/packages/common/src/directives/ng_for_of.ts b/packages/common/src/directives/ng_for_of.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Directive, DoCheck, EmbeddedViewRef, Input, isDevMode, IterableChangeRecord, IterableChanges, IterableDiffer, IterableDiffers, NgIterable, TemplateRef, TrackByFunction, ViewContainerRef} from '@angular/core';
+import {Directive, DoCheck, EmbeddedViewRef, Input, IterableChangeRecord, IterableChanges, IterableDiffer, IterableDiffers, NgIterable, TemplateRef, TrackByFunction, ViewContainerRef} from '@angular/core';
 
 /**
  * @publicApi
@@ -159,7 +159,7 @@ export class NgForOf<T, U extends NgIterable<T> = NgIterable<T>> implements DoCh
    */
   @Input()
   set ngForTrackBy(fn: TrackByFunction<T>) {
-    if (isDevMode() && fn != null && typeof fn !== 'function') {
+    if ((typeof ngDevMode === 'undefined' || ngDevMode) && fn != null && typeof fn !== 'function') {
       // TODO(vicb): use a log service once there is a public one available
       if (<any>console && <any>console.warn) {
         console.warn(
diff --git a/packages/common/src/pipes/number_pipe.ts b/packages/common/src/pipes/number_pipe.ts
@@ -241,7 +241,7 @@ export class CurrencyPipe implements PipeTransform {
     locale = locale || this._locale;
 
     if (typeof display === 'boolean') {
-      if (<any>console && <any>console.warn) {
+      if ((typeof ngDevMode === 'undefined' || ngDevMode) && <any>console && <any>console.warn) {
         console.warn(
             `Warning: the currency pipe has been changed in Angular v5. The symbolDisplay option (third parameter) is now a string instead of a boolean. The accepted values are "code", "symbol" or "symbol-narrow".`);
       }

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ export class CurrencyPipe implements PipeTransform {`
`241`	`241`	`locale = locale \|\| this._locale;`
`242`	`242`
`243`	`243`	`if (typeof display === 'boolean') {`
`244`		`- if (<any>console && <any>console.warn) {`
	`244`	`+ if ((typeof ngDevMode === 'undefined' \|\| ngDevMode) && <any>console && <any>console.warn) {`
`245`	`245`	`console.warn(`
`246`	`246`	`Warning: the currency pipe has been changed in Angular v5. The symbolDisplay option (third parameter) is now a string instead of a boolean. The accepted values are "code", "symbol" or "symbol-narrow".`);
`247`	`247`	`}`