Skip to content

fix: resolve bot workflow runtime failure #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Abhijeet2409 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve bot workflow runtime failure #1789

Abhijeet2409 wants to merge 2 commits into from
+1 −6

Conversation

@Abhijeet2409
Copy link
Contributor

@Abhijeet2409 Abhijeet2409 commented Feb 11, 2026 •
edited
Loading

This PR resolves a runtime failure in bot-workflows.js caused by overly strict validation of FAILED_WORKFLOW_NAME.

Fix

Removed the strict validation block for FAILED_WORKFLOW_NAME.

This is safe because:

  • The value is only logged and not used in shell execution or API path construction.
  • GitHub provides the workflow name, so additional validation is unnecessary.

Testing

Closes #1690

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Hi @Abhijeet2409, this is **LinkBot** 👋

Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy.

🚨 This pull request does not have an issue linked.

Please link an issue using the following format:

Fixes #123

📖 Guide:
docs/sdk_developers/how_to_link_issues.md

If no issue exists yet, please create one:
docs/sdk_developers/creating_issues.md

Thanks!

@Abhijeet2409 Abhijeet2409 force-pushed the fix/bot-workflows-runtime branch from 8fdd975 to 6ce82ae Compare February 11, 2026 22:54
@Abhijeet2409 Abhijeet2409 force-pushed the fix/bot-workflows-runtime branch from 6ce82ae to f26e953 Compare February 11, 2026 23:00
@Abhijeet2409 Abhijeet2409 marked this pull request as ready for review February 11, 2026 23:05
@Abhijeet2409 Abhijeet2409 requested review from a team as code owners February 11, 2026 23:05
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026 •
edited
Loading

Walkthrough

Removes the runtime character validation for the FAILED_WORKFLOW_NAME environment variable in .github/scripts/bot-workflows.js and updates CHANGELOG.md with a note about the fix.

Changes

Cohort / File(s) Summary
Bot Workflow Script
​.github/scripts/bot-workflows.js		 Deleted the runtime validation that enforced /^[\w\s\-\.]+$/ on FAILED_WORKFLOW_NAME, removing the early-exit check for invalid characters.
Changelog
CHANGELOG.md		 Added an entry noting the fix: bot workflow runtime failure caused by strict FAILED_WORKFLOW_NAME validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely summarizes the main change: resolving a bot workflow runtime failure by removing overly strict validation.
Description check ✅ Passed The description clearly explains the fix, rationale, and testing performed, directly addressing the runtime failure issue mentioned in the linked issue.
Linked Issues check ✅ Passed The PR fully addresses issue #1690 by fixing the runtime error in bot-workflows.js through removal of strict FAILED_WORKFLOW_NAME validation, includes a changelog entry, and demonstrates testing.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the bot-workflows.js runtime issue and updating the changelog as required by the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

coderabbitai[bot]
coderabbitai bot reviewed Feb 12, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

CHANGELOG.md
- Refactored SDK dependencies to use version ranges, moved build-only deps out of runtime, removed unused core deps and added optional extras.

### Fixed
- Fixed bot workflow runtime failure caused by strict `FAILED_WORKFLOW_NAME` validation. (`#1690`)
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

LGTM! Spacing issue resolved.

The changelog entry accurately describes the fix and correctly addresses the previous review comment about spacing. The entry is now consistent with most other entries that include a space before the issue reference.

Optional nitpick: For maximum consistency, consider using plain parentheses (#1690) instead of backticks around the issue reference, as the majority of entries in the Fixed section use this format (e.g., lines 287-291). However, this is minor since backticks do appear elsewhere (line 285).

✨ Optional formatting adjustment for consistency 
-- Fixed bot workflow runtime failure caused by strict `FAILED_WORKFLOW_NAME` validation. (`#1690`)
+- Fixed bot workflow runtime failure caused by strict `FAILED_WORKFLOW_NAME` validation. (`#1690`)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Fixed bot workflow runtime failure caused by strict `FAILED_WORKFLOW_NAME` validation. (`#1690`)
- Fixed bot workflow runtime failure caused by strict `FAILED_WORKFLOW_NAME` validation. (`#1690`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@nadineloepfe nadineloepfe Awaiting requested review from nadineloepfe nadineloepfe is a code owner automatically assigned from hiero-ledger/hiero-sdk-python-maintainers

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hiero-ledger/github-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Intermediate]: Fix .github/scripts/bot-workflows.js run issue

1 participant

@Abhijeet2409