Fix getrandom 0.4.1 compatibility in random module#7180
Closed
Copilot wants to merge 3 commits intodependabot/cargo/getrandom-0.4.1from
Closed
Fix getrandom 0.4.1 compatibility in random module#7180Copilot wants to merge 3 commits intodependabot/cargo/getrandom-0.4.1from
Copilot wants to merge 3 commits intodependabot/cargo/getrandom-0.4.1from
Conversation
Co-authored-by: youknowone <[email protected]>
Co-authored-by: youknowone <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update getrandom from 0.3.4 to 0.4.1
Fix getrandom 0.4.1 compatibility in random module
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getrandom 0.4.1 upgrade broke the build due to incompatible error type conversions in the random module. The mt19937 crate returns getrandom 0.3.x errors, but the code attempted to convert them using
From<getrandom::Error>which is not compatible across versions.Changes
crates/stdlib/src/random.rs:64: Replacestd::io::Error::from(e)withstd::io::Error::other(e.to_string())The
std::io::Error::other()method accepts anyDisplaytype, making it version-agnostic for error conversions.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.