Skip to content

Commit 4b04f28

Browse files
committed
fix missing comma in .rc files, now MinGw can add resources, change dos stub, and sign target binaries, but the resources are not reflected for some reason
1 parent 11f052b commit 4b04f28

File tree

8 files changed

+16
-16
lines changed

8 files changed

+16
-16
lines changed

resources/win/api/32/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3333

3434
BLOCK "VarFileInfo"
3535
{
36-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
36+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3737
}
3838
}
3939

@@ -78,6 +78,6 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
7878

7979
BLOCK "VarFileInfo"
8080
{
81-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
81+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
8282
}
8383
}

resources/win/api/64/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3030

3131
BLOCK "VarFileInfo"
3232
{
33-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
33+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3434
}
3535
}
3636

@@ -65,6 +65,6 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
6565

6666
BLOCK "VarFileInfo"
6767
{
68-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
68+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
6969
}
7070
}

resources/win/client/32/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3030

3131
BLOCK "VarFileInfo"
3232
{
33-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
33+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3434
}
3535
}
3636

@@ -65,7 +65,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
6565

6666
BLOCK "VarFileInfo"
6767
{
68-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
68+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
6969
}
7070
}
7171

resources/win/client/64/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3030

3131
BLOCK "VarFileInfo"
3232
{
33-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
33+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3434
}
3535
}
3636

@@ -65,7 +65,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
6565

6666
BLOCK "VarFileInfo"
6767
{
68-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
68+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
6969
}
7070
}
7171

resources/win/game_overlay_renderer/32/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3030

3131
BLOCK "VarFileInfo"
3232
{
33-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
33+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3434
}
3535
}
3636

@@ -65,7 +65,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
6565

6666
BLOCK "VarFileInfo"
6767
{
68-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
68+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
6969
}
7070
}
7171

resources/win/game_overlay_renderer/64/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3030

3131
BLOCK "VarFileInfo"
3232
{
33-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
33+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3434
}
3535
}
3636

@@ -65,7 +65,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
6565

6666
BLOCK "VarFileInfo"
6767
{
68-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
68+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
6969
}
7070
}
7171

resources/win/launcher/32/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3030

3131
BLOCK "VarFileInfo"
3232
{
33-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
33+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3434
}
3535
}
3636

@@ -65,6 +65,6 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
6565

6666
BLOCK "VarFileInfo"
6767
{
68-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
68+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
6969
}
7070
}

resources/win/launcher/64/resources.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
3030

3131
BLOCK "VarFileInfo"
3232
{
33-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
33+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
3434
}
3535
}
3636

@@ -65,6 +65,6 @@ FILESUBTYPE 0x0L // VFT2_UNKNOWN
6565

6666
BLOCK "VarFileInfo"
6767
{
68-
VALUE "Translation", 0x0409 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
68+
VALUE "Translation", 0x0409, 0x04B0 // English language (0x409) in the Windows ANSI codepage (1252)
6969
}
7070
}

0 commit comments

Comments
 (0)