Merged
Conversation
Owner
|
I don't think you an extra call to Python if the build is free-threaded. The nanobind CMake build system already knows this through the ABI tag. |
Contributor
Author
|
Done.. much cleaner. I think you can review it. |
Contributor
|
Do we still want to have To answer my own question: yes, we want to keep the argument. |
Owner
|
THanks. This looks good now. I will make a minor touchup and reduce the length of the variable name. |
wjakob
pushed a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wjakob wdyt about something like this (codex did it)? It queries the active interpreter for
Py_GIL_DISABLEDand sets a new build flagNB_PY_GIL_DISABLEDwhich it uses to addnb_ft.cppto the target or not.