Skip to content

fix(runtime-core): skip patching reserved props for custom elements #14275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 3 commits into from
Jan 19, 2026
Merged

fix(runtime-core): skip patching reserved props for custom elements #14275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4ed61c
fix(runtime-core): skip patching reserved props for custom elements
danielroe Jan 4, 2026
e5c2f8e
chore: add comment linking to issue
danielroe Jan 4, 2026
6153b49
test: add assertion that ref is correctly assigned
danielroe Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/runtime-core/__tests__/hydration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,6 +1597,24 @@ describe('SSR hydration', () => {
expect((container.firstChild as any).foo).toBe(msg.value)
})

// #14274
test('should not render ref on custom element during hydration', () => {
const container = document.createElement('div')
container.innerHTML = '<my-element>hello</my-element>'
const root = ref()
const app = createSSRApp({
render: () =>
h('my-element', {
ref: root,
innerHTML: 'hello',
}),
})
app.mount(container)
expect(container.innerHTML).toBe('<my-element>hello</my-element>')
expect((container.firstChild as Element).hasAttribute('ref')).toBe(false)
expect(root.value).toBe(container.firstChild)
})

// #5728
test('empty text node in slot', () => {
const Comp = {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/hydration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ export function createHydrationFunctions(
(isOn(key) && !isReservedProp(key)) ||
// force hydrate v-bind with .prop modifiers
key[0] === '.' ||
isCustomElement
(isCustomElement && !isReservedProp(key))
) {
patchProp(el, key, null, props[key], undefined, parentComponent)
}
Expand Down
Loading