fix(runtime-core): support any signature for Options API lifecycle#5914
Merged
yyx990803 merged 2 commits intovuejs:mainfrom Nov 19, 2024
Merged
fix(runtime-core): support any signature for Options API lifecycle#5914yyx990803 merged 2 commits intovuejs:mainfrom
yyx990803 merged 2 commits intovuejs:mainfrom
Conversation
yyx990803
requested changes
May 18, 2022
Size ReportBundles
Usages
|
@vue/compiler-dom
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/shared
@vue/server-renderer
@vue/compat
vue
commit: |
|
@yyx990803 Is this change ready to be merged? We have a number of async mounted calls in our options API and would love to have these changes in place. It's a large codebase with a lot of legacy components that can't be readily converted to composition API. Thanks so much. |
yyx990803
approved these changes
Nov 19, 2024
abdullah-wn
pushed a commit
to Lazy-work/vue
that referenced
this pull request
Jan 4, 2025
) Co-authored-by: edison <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5909
fix(runtime-core): support any signature for Options API lifecycle