packages/compiler-sfc/src/script/resolveType.ts (1)

1048-1054: Minor style improvement – use optional chaining

Static-analysis already hints at it. The manual excluded && … can be trimmed:

-          if (
-            excluded &&
-            excluded.some(p => isMatch(containingFile, getPattern(base, p)))
-          ) {
+          if (
+            excluded?.some(p => isMatch(containingFile, getPattern(base, p)))
+          ) {
             continue
           }

Touches no logic, just terser & consistent with the included?.some above.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/compiler-sfc/src/script/resolveType.ts (2)

1032-1039: Minor refactor opportunity: lift helper + version parsing out of the loop

const [major, minor] = … and function getPattern… are recreated every time resolveWithTS is invoked. They only depend on ts.versionMajorMinor and configPath, both of which are invariant during a single compiler run. Hoisting them to the outer scope of resolveWithTS (or caching the parsed tuple) would avoid unnecessary re-allocation and keep the loop body slimmer.

Not critical, just a readability / micro-perf improvement.

---

1050-1055: Use optional chaining to streamline excluded check

Small readability tweak: the explicit null check can be replaced with optional chaining.

-          if (
-            excluded &&
-            excluded.some(p => isMatch(containingFile, getPattern(base, p)))
-          ) {
+          if (
+            excluded?.some(p => isMatch(containingFile, getPattern(base, p)))
+          ) {

No behavioural change; simply reduces nesting.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/compiler-sfc/src/script/resolveType.ts (2)

1032-1039: Protect against pre-release version strings & compute once

Good call switching to major > 5 || (major === 5 && minor >= 5) – it future-proofs the guard.
Two minor nits:

1. Number('5.5-beta') becomes NaN, disabling the feature for nightly/beta drops.
   Use parseInt (or a regex) to strip non-digits first.

2. supportsConfigDir is recalculated on every getPattern invocation although it’s invariant – lift it outside the arrow for micro clarity.

-const [major, minor] = ts.versionMajorMinor.split('.').map(Number)
+const [majorRaw, minorRaw] = ts.versionMajorMinor.split('.')
+const major = parseInt(majorRaw, 10)
+const minor = parseInt(minorRaw, 10)

-const getPattern = (base: string, p: string) => {
-  // ts 5.5+ supports ${configDir} in paths
-  const supportsConfigDir = major > 5 || (major === 5 && minor >= 5)
+// ts 5.5+ supports ${configDir} in paths
+const supportsConfigDir = major > 5 || (major === 5 && minor >= 5)
+
+const getPattern = (base: string, p: string) => {

---

1049-1055: Use optional chaining to quiet lint & improve readability

Biome flags this pattern check; a terse optional-chain keeps the meaning while removing an explicit null-guard:

-        if (
-          (!included && (!base || containingFile.startsWith(base))) ||
-          included?.some(p => isMatch(containingFile, getPattern(base, p)))
-        ) {
+        if (
+          (!included && (!base || containingFile.startsWith(base))) ||
+          included?.some(p => isMatch(containingFile, getPattern(base, p)))
+        ) {
           if (
-            excluded &&
-            excluded.some(p => isMatch(containingFile, getPattern(base, p)))
+            excluded?.some(p =>
+              isMatch(containingFile, getPattern(base, p)),
+            )
           ) {

This is purely stylistic – feel free to keep the existing guard if you prefer explicit checks.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro