fix!: ignore --standalone when CLI filename filter is used#8262
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Jul 15, 2025
Merged
fix!: ignore --standalone when CLI filename filter is used#8262sheremet-va merged 2 commits intovitest-dev:mainfrom
--standalone when CLI filename filter is used#8262sheremet-va merged 2 commits intovitest-dev:mainfrom
Conversation
AriPerkkio
commented
Jul 5, 2025
Comment on lines
+153
to
+155
| if (options.standalone && (cliFilters?.length || 0) > 0) { | ||
| options.standalone = false | ||
| } |
Member
Author
There was a problem hiding this comment.
This seemed like the best place to do this. The resolveConfig doesn't have cliFilters in the scope.
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
force-pushed
the
fix/standalone-with-filter
branch
2 times, most recently
from
9b8aafc to
e2aa332
Compare
AriPerkkio
force-pushed
the
fix/standalone-with-filter
branch
from
e2aa332 to
8e2bd87
Compare
AriPerkkio
changed the title
--standalone when CLI filename filter is used--standalone when CLI filename filter is used
sheremet-va
previously approved these changes
Jul 14, 2025
Member
sheremet-va
left a comment
sheremet-va
left a comment
There was a problem hiding this comment.
Can we also add a note to the migration guide?
sheremet-va
approved these changes
Jul 15, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change to improve overall user experience. It makes sense to start the test run when
--standaloneis used with CLI filename filter.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.