test: Fix typo in validators.test.js#2581
Conversation
Use `locale:` instead of `local:` for isPhoneNumber test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2581 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2535 2535
Branches 641 641
=========================================
Hits 2535 2535 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Good catch! However this should have been an error in the test runs before, I'll look into why we haven't implemented such a check |
|
From what I understood this just goes into the |
Yes, something like that seems to be happening indeed. I've added a check locally for other unexpected attributes in that fixtures array but those seem good. When we do a bigger update to the test helper functions I'll add that (or when we move to TypeScript). For now this change is fine to merge |
Use
locale:instead oflocal:for isPhoneNumber test.Checklist