fix(removeEmptyContainers): skip if filter is applied via styles as well#2089
Merged
fix(removeEmptyContainers): skip if filter is applied via styles as well#2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where we were too eager to remove empty containers.
We already had logic to skip removing empty containers if it had the
filterattribute, which is needed to apply a filter to the whole area. However, thefiltercan also be defined through CSS. We did not properly handle this case, and treated the node as if it had nofilterat all.This computes the styles and checks the stylesheet as well. (We also move the logic down to avoid computing the styles eagerly.)