add back and deprecate IO.close(InputStream)#3756
Merged
hazendaz merged 1 commit intospotbugs:masterfrom Oct 8, 2025
Merged
Conversation
JuditKnoll
force-pushed
the
io-close-deprecate
branch
from
a05e0fe to
e3ffff9
Compare
ThrawnCA
approved these changes
Oct 8, 2025
hazendaz
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During modernizing the
edu.umd.cs.findbugs.io.IO.close(InputStream)method was removed in #3683. It turns out it is used in FindSecBugs and causes issues (see find-sec-bugs/find-sec-bugs#766).This PR reverts this part of that PR and deprecates the method.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code