Fix false CLASS_NOW_NOT_EXTENDABLE for added private constructors - #527
Merged
siom79 merged 1 commit intoSep 3, 2026
Merged
Conversation
dossett
marked this pull request as draft
September 3, 2026 14:48
dossett
marked this pull request as ready for review
September 3, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a private constructor to a class whose constructors are already all private does not make that class less extendable. The current comparison includes constructors from both versions, so a constructor absent from the old version is treated like an old non-private constructor and produces a false breaking-change report.
This change evaluates only constructors present in the selected version while preserving final-class and empty-constructor behavior. The regression test covers adding a private overload to a class that already has one private constructor.
Testing:
Fixes #526