Conversation
asolntsev
force-pushed
the
download-files-in-grid
branch
from
f50e0f5 to
869602f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| HttpResponse response = client.execute(request); | ||
| FileContentResponse fileContent = parseDownloadedFile(Contents.string(response)); | ||
| Zip.unzip(fileContent.value().contents(), targetFolder); | ||
| File file = new File(targetFolder, fileName); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
P.S. Removed few duplicate test-cases from FileDownloadToFolderTest
we are not stopping the previous servers, thus getting OutOfMemory very quickly.
asolntsev
force-pushed
the
download-files-in-grid
branch
from
869602f to
4971ee9
Compare
BorisOsipov
reviewed
Feb 22, 2024
asolntsev
force-pushed
the
download-files-in-grid
branch
from
de95bad to
3bf2c7c
Compare
|
asolntsev
added a commit
that referenced
this pull request
Feb 24, 2024
I realized that RemoteWebDriver already contains methods `getDownloadableFiles`, `downloadFile` `deleteDownloadableFiles` :)
asolntsev
added a commit
that referenced
this pull request
Feb 24, 2024
I realized that RemoteWebDriver already contains methods `getDownloadableFiles`, `downloadFile` `deleteDownloadableFiles` :)
asolntsev
added a commit
that referenced
this pull request
Feb 25, 2024
I realized that RemoteWebDriver already contains methods `getDownloadableFiles`, `downloadFile` `deleteDownloadableFiles` :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now method
$.download(FOLDER)works in Selenium Grid too.