Actually use configured crypto provider for the platform verifier#293
Merged
djc merged 2 commits intorustls:mainfrom Dec 17, 2024
Merged
Conversation
Signed-off-by: Jens Reidel <[email protected]>
djc
approved these changes
Dec 17, 2024
Member
djc
left a comment
There was a problem hiding this comment.
Ohh, thanks for that! Silly mistake...
Can you add in a commit that bumps the version number?
cpu
approved these changes
Dec 17, 2024
Signed-off-by: Jens Reidel <[email protected]>
Contributor
Author
Done :) |
ctz
approved these changes
Dec 17, 2024
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustls-platform-verifier'sVerifierneeds to be told about the provider that is being used, otherwise it would error if no process-wide default had been installed.with_provider_and_platform_verifierdoes create theClientConfigwith the crypto provider and then callswith_platform_verifier, but the platform verifier was previously never made aware of the crypto provider.