Fix incorrect autocorrect for Style/AccessModifierDeclarations#14354
Merged
koic merged 1 commit intorubocop:masterfrom Jul 10, 2025
Merged
Fix incorrect autocorrect for Style/AccessModifierDeclarations#14354koic merged 1 commit intorubocop:masterfrom
koic merged 1 commit intorubocop:masterfrom
Conversation
093ad5e to
6586212
Compare
6586212 to
1e2d281
Compare
koic
reviewed
Jul 10, 2025
| @@ -0,0 +1 @@ | |||
| * [#14354](https://github.com/rubocop/rubocop/pull/14354): Fix incorrect autocorrect for `Style/AccessModifierDeclarations`. ([@girasquid][]) | |||
Member
There was a problem hiding this comment.
Can you add a bit more context? e.g.,
Suggested change
| * [#14354](https://github.com/rubocop/rubocop/pull/14354): Fix incorrect autocorrect for `Style/AccessModifierDeclarations`. ([@girasquid][]) | |
| * [#14354](https://github.com/rubocop/rubocop/pull/14354): Fix incorrect autocorrect for `Style/AccessModifierDeclarations` when using a grouped access modifier declaration. ([@girasquid][]) |
koic
reviewed
Jul 10, 2025
| RUBY | ||
| end | ||
|
|
||
| it 'does not delete methods before the group declaration' do |
Member
There was a problem hiding this comment.
Can you update it? The description in it should only state the condition under which an offense is registered.
Suggested change
| it 'does not delete methods before the group declaration' do | |
| it 'registers an offense when using a grouped access modifier declaration' do |
Contributor
Author
There was a problem hiding this comment.
That's a great improvement, I couldn't figure out what to describe this with - thanks for the suggestion, done 👍🏻
1e2d281 to
fe4196d
Compare
…sing a grouped access modifier declaration.
fe4196d to
1cfebee
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when running autocorrect for
Style/AccessModifierDeclarations, the method above the group declaration was being deleted. So this:After going through autocorrect would become:
This PR adds a spec demonstrating the behavior with as small a code sample as I could get down to, and then fixes the issue - when trying to change the code it was always using index
1, which wasn't correct if the AST had the entire class body for what needed to be processed.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.