Fix incorrect autocorrect for Lint/RedundantTypeConversion#14319
Merged
koic merged 1 commit intorubocop:masterfrom Jun 21, 2025
Merged
Conversation
This PR fixes the following incorrect autocorrect for `Lint/RedundantTypeConversion`
when using parentheses with no arguments or any arguments.
## Case 1: Parentheses with no arguments
First, this applies to parentheses with no arguments.
```console
$ echo '{k => v}.to_h()' | bundle exec rubocop --stdin test.rb -a --only Lint/RedundantTypeConversion
Inspecting 1 file
F
Offenses:
test.rb:1:9: F: Lint/Syntax: unexpected token tLPAREN2
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
{k => v}()
^
test.rb:1:10: W: [Corrected] Lint/RedundantTypeConversion: Redundant to_h detected.
{k => v}.to_h()
^^^^
1 file inspected, 2 offenses detected, 1 offense corrected
====================
{k => v}()
```
It is currently autocorrected to an invalid syntax with unnecessary parentheses.
Since this case is syntactically valid, it will be updated to the correct form `{k => v}` without parentheses.
## Case 2: Parentheses with arguments
Next, the case with arguments.
```console
$ echo '{k => v}.to_h(arg)' | bundle exec rubocop --stdin test.rb -a --only Lint/RedundantTypeConversion
Inspecting 1 file
F
Offenses:
test.rb:1:9: F: Lint/Syntax: unexpected token tLPAREN2
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
{k => v}(arg)
^
test.rb:1:10: W: [Corrected] Lint/RedundantTypeConversion: Redundant to_h detected.
{k => v}.to_h(arg)
^^^^
1 file inspected, 2 offenses detected, 1 offense corrected
====================
{k => v}(arg)
```
This case also results in an incorrect autocorrection. However, when arguments are present,
the method should be assumed to be either overridden or still under programming, and thus ignored.
In any case, it cannot be considered safely removable or redundant.
e733037 to
e9ba3ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following incorrect autocorrect for
Lint/RedundantTypeConversionwhen using parentheses with no arguments or any arguments.Case 1: Parentheses with no arguments
First, this applies to parentheses with no arguments.
It is currently autocorrected to an invalid syntax with unnecessary parentheses. Since this case is syntactically valid, it will be updated to the correct form
{k => v}without parentheses.Case 2: Parentheses with arguments
Next, the case with arguments.
This case also results in an incorrect autocorrection. However, when arguments are present, the method should be assumed to be either overridden or still under programming, and thus ignored. In any case, it cannot be considered safely removable or redundant.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.