Fix incorrect disabling of departments when inheriting configuration#13942
Merged
bbatsov merged 1 commit intorubocop:masterfrom Mar 4, 2025
Merged
Conversation
This fixes an issue where departments that were disabled in `rubocop-i18n` were unexpectedly enabled, even when they were also disabled in the user configuration. Since `override_department_setting_for_cops` is processed in `resolve_inheritance`, unnecessary calls were being made. This caused `'override_department'` to be unexpectedly set for cop's `Enabled`. It seems that part of the configuration processing changes introduced with plugin support was missed. Fixes rubocop/rubocop-i18n#66.
koic
force-pushed
the
fix_disabling_of_departments_when_inheriting_configuration
branch
from
c0f43f6 to
4c09f85
Compare
Collaborator
|
Thanks! |
koic
deleted the
fix_disabling_of_departments_when_inheriting_configuration
branch
Contributor
|
I have seen similar config problems in other gems, when I have an exceptionally deep stack of rubocop gems. Thanks for finding this, I expect there is a decent chance the other issues had the same root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where departments that were disabled in
rubocop-i18nwere unexpectedly enabled, even when they were also disabled in the user configuration.Since
override_department_setting_for_copsis processed inresolve_inheritance, unnecessary calls were being made. This caused'override_department'to be unexpectedly set for cop'sEnabled.It seems that part of the configuration processing changes introduced with plugin support was missed.
Fixes rubocop/rubocop-i18n#66.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.