Fix writing generics type of rbs-inline annotation for nested class in Style/CommentedKeyword#13915
Merged
koic merged 1 commit intorubocop:masterfrom Feb 27, 2025
Conversation
dak2
force-pushed
the
rbs-inline/generics-type-in-commented-keyword-for-nested-class
branch
from
44dad0b to
8690d7d
Compare
koic
reviewed
Feb 26, 2025
| REGEXP = /(?<keyword>\S+).*#/.freeze | ||
|
|
||
| SUBCLASS_DEFINITION = /\A\s*class\s+\w+\s*<\s*\w+/.freeze | ||
| SUBCLASS_DEFINITION = /\A\s*class\s+[\w:]+\s*<\s*[\w:]+/.freeze |
Member
There was a problem hiding this comment.
I think using :: makes it clearer as an identifier. What do you think?
Suggested change
| SUBCLASS_DEFINITION = /\A\s*class\s+[\w:]+\s*<\s*[\w:]+/.freeze | |
| SUBCLASS_DEFINITION = /\A\s*class\s+(\w|::)+\s*<\s*(\w|::)+/.freeze |
Contributor
Author
There was a problem hiding this comment.
@koic
Thanks for the suggestion!!
I adopted it because it's clearer than my implement.
…n `Style/CommentedKeyword` [RBS::Inline](https://github.com/soutaro/rbs-inline) is a utility to embed RBS type declarations into Ruby code as comments. I made rules for generics type below pull request, but nested classes were not supported. Follow rubocop#13476
dak2
force-pushed
the
rbs-inline/generics-type-in-commented-keyword-for-nested-class
branch
from
8690d7d to
0e33424
Compare
Member
|
Thanks! |
dak2
deleted the
rbs-inline/generics-type-in-commented-keyword-for-nested-class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RBS::Inline is a utility to embed RBS type declarations into Ruby code as comments.
I made rules for generics type below pull request, but nested classes were not supported.
Follow #13476
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.